Bug 174774 - [GStreamer] Don't use GraphicsContext3D in VideoTextureCoperGStreamer
Summary: [GStreamer] Don't use GraphicsContext3D in VideoTextureCoperGStreamer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks: 174860
  Show dependency treegraph
 
Reported: 2017-07-24 00:10 PDT by Zan Dobersek
Modified: 2017-08-08 06:29 PDT (History)
4 users (show)

See Also:


Attachments
WIP (11.53 KB, patch)
2017-07-24 00:10 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch (13.29 KB, patch)
2017-08-08 04:16 PDT, Zan Dobersek
cgarcia: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2017-07-24 00:10:04 PDT
[GStreamer] Don't use GraphicsContext3D in VideoTextureCoperGStreamer
Comment 1 Zan Dobersek 2017-07-24 00:10:55 PDT
Created attachment 316271 [details]
WIP
Comment 2 Build Bot 2017-07-24 00:12:59 PDT
Attachment 316271 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Zan Dobersek 2017-08-08 04:16:40 PDT
Created attachment 317559 [details]
Patch
Comment 4 Build Bot 2017-08-08 04:18:22 PDT
Attachment 317559 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/gstreamer/VideoTextureCopierGStreamer.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Carlos Garcia Campos 2017-08-08 06:25:50 PDT
Comment on attachment 317559 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317559&action=review

> Source/WebCore/platform/graphics/gstreamer/VideoTextureCopierGStreamer.cpp:30
> +// FIXME: Remove avter TextureMapperShaderProgram drops GraphicsContext3D usage.

after?

> Source/WebCore/platform/graphics/gstreamer/VideoTextureCopierGStreamer.cpp:42
> +        // FIXME: Remove avter TextureMapperShaderProgram drops GraphicsContext3D usage.

Ditto.
Comment 6 Zan Dobersek 2017-08-08 06:29:34 PDT
Committed r220402: <http://trac.webkit.org/changeset/220402>