Bug 174837 – Make run-javascriptcore-test run testair, testb3, and testmasm.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Mark Lam]

Coming soon.

[Radar WebKit Bug Importer]

<rdar://problem/33522927>

[Mark Lam]

Created attachment 316465 [details]
proposed patch.

[Build Bot]

Comment on attachment 316465 [details]
proposed patch.

Attachment 316465 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4192166

New failing tests:
imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html

[Build Bot]

Created attachment 316480 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Mark Lam]

(In reply to Build Bot from comment #4)
> Created attachment 316480 [details]
> Archive of layout-test-results from ews126 for ios-simulator-wk2
> 
> The attached test failures were seen while running run-webkit-tests on the
> ios-sim-ews.
> Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

This test failure has to be bogus because I didn't change the layout tests nor any source code (as opposed to the run-jsvaascriptcore-tests script).

[Saam Barati]

Comment on attachment 316465 [details]
proposed patch.

r=me

[Filip Pizlo]

Comment on attachment 316465 [details]
proposed patch.

r=me too

[Mark Lam]

Thanks for the review.  Landed in r219965: <http://trac.webkit.org/r219965>.

[Alexey Proskuryakov]

Could you please update the dashboard too? Running the tests on bots is of little use if we can't see the results.

Also, I'm not sure how this impacts EWS, unexpected subtests might break it.

[Mark Lam]

(In reply to Alexey Proskuryakov from comment #9)
> Could you please update the dashboard too? Running the tests on bots is of
> little use if we can't see the results.
> 
> Also, I'm not sure how this impacts EWS, unexpected subtests might break it.

We can see the results to the extent that we can see failures in testapi today ... which results in a crash, and the jsc stress tests, etc not running.  The same goes for these new tests: if there's a failure, it crashes.

[Aakash Jain]

> Could you please update the dashboard too? Running the tests on bots is of
> little use if we can't see the results.

Dashboard already shows JSC tests (Debug and Release). Since this patch just adds more tests in the same run-javascriptcore-tests script, and dashboard already parses the output of run-javascriptcore-tests, it seems that dashboard should just work. Please let me know if it doesn't.

[Alexey Proskuryakov]

How exactly does it look on the dashboard when (for example) testair fails?