Bug 174837 - Make run-javascriptcore-test run testair, testb3, and testmasm.
Summary: Make run-javascriptcore-test run testair, testb3, and testmasm.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks: 174645
  Show dependency treegraph
 
Reported: 2017-07-25 14:57 PDT by Mark Lam
Modified: 2017-07-28 14:49 PDT (History)
12 users (show)

See Also:


Attachments
proposed patch. (8.35 KB, patch)
2017-07-26 12:52 PDT, Mark Lam
saam: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (13.41 MB, application/zip)
2017-07-26 14:19 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2017-07-25 14:57:08 PDT
Coming soon.
Comment 1 Radar WebKit Bug Importer 2017-07-25 14:58:30 PDT
<rdar://problem/33522927>
Comment 2 Mark Lam 2017-07-26 12:52:45 PDT
Created attachment 316465 [details]
proposed patch.
Comment 3 Build Bot 2017-07-26 14:19:45 PDT
Comment on attachment 316465 [details]
proposed patch.

Attachment 316465 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4192166

New failing tests:
imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html
Comment 4 Build Bot 2017-07-26 14:19:47 PDT
Created attachment 316480 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 5 Mark Lam 2017-07-26 14:28:13 PDT
(In reply to Build Bot from comment #4)
> Created attachment 316480 [details]
> Archive of layout-test-results from ews126 for ios-simulator-wk2
> 
> The attached test failures were seen while running run-webkit-tests on the
> ios-sim-ews.
> Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

This test failure has to be bogus because I didn't change the layout tests nor any source code (as opposed to the run-jsvaascriptcore-tests script).
Comment 6 Saam Barati 2017-07-26 14:56:59 PDT
Comment on attachment 316465 [details]
proposed patch.

r=me
Comment 7 Filip Pizlo 2017-07-26 14:57:38 PDT
Comment on attachment 316465 [details]
proposed patch.

r=me too
Comment 8 Mark Lam 2017-07-26 15:16:10 PDT
Thanks for the review.  Landed in r219965: <http://trac.webkit.org/r219965>.
Comment 9 Alexey Proskuryakov 2017-07-27 13:37:35 PDT
Could you please update the dashboard too? Running the tests on bots is of little use if we can't see the results.

Also, I'm not sure how this impacts EWS, unexpected subtests might break it.
Comment 10 Mark Lam 2017-07-27 13:42:30 PDT
(In reply to Alexey Proskuryakov from comment #9)
> Could you please update the dashboard too? Running the tests on bots is of
> little use if we can't see the results.
> 
> Also, I'm not sure how this impacts EWS, unexpected subtests might break it.

We can see the results to the extent that we can see failures in testapi today ... which results in a crash, and the jsc stress tests, etc not running.  The same goes for these new tests: if there's a failure, it crashes.
Comment 11 Aakash Jain 2017-07-28 13:20:26 PDT
> Could you please update the dashboard too? Running the tests on bots is of
> little use if we can't see the results.

Dashboard already shows JSC tests (Debug and Release). Since this patch just adds more tests in the same run-javascriptcore-tests script, and dashboard already parses the output of run-javascriptcore-tests, it seems that dashboard should just work. Please let me know if it doesn't.
Comment 12 Alexey Proskuryakov 2017-07-28 14:49:26 PDT
How exactly does it look on the dashboard when (for example) testair fails?