Bug 174809 – Fix bugs in probe code to change sp on x86, x86_64 and 32-bit ARM.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

Patch coming.

[Radar WebKit Bug Importer]

<rdar://problem/33504759>

[Mark Lam]

Created attachment 316347 [details]
proposed patch.

[Build Bot]

Attachment 316347 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/assembler/testmasm.cpp:226:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
ERROR: Source/JavaScriptCore/assembler/testmasm.cpp:271:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
ERROR: Source/JavaScriptCore/assembler/testmasm.cpp:272:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
ERROR: Source/JavaScriptCore/assembler/testmasm.cpp:318:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
ERROR: Source/JavaScriptCore/assembler/testmasm.cpp:423:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
ERROR: Source/JavaScriptCore/assembler/testmasm.cpp:474:  Consider using CHECK_EQ instead of CHECK(a == b)  [readability/check] [2]
Total errors found: 6 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Filip Pizlo]

Comment on attachment 316347 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=316347&action=review

Does testmasm run on any bots?  Maybe it should!

> Source/JavaScriptCore/assembler/testmasm.cpp:321
> +void testProbeModifiesStackPointer(std::function<void*(ProbeContext*)> computeModifiedStack)

Would WTF::Function work here?

[Mark Lam]

Thanks for the review.

(In reply to Filip Pizlo from comment #4)
> Does testmasm run on any bots?  Maybe it should!

I'll talk to the relevant folks to get this going.

> > Source/JavaScriptCore/assembler/testmasm.cpp:321
> > +void testProbeModifiesStackPointer(std::function<void*(ProbeContext*)> computeModifiedStack)
> 
> Would WTF::Function work here?

I've changed all uses of std::function in testmasm.cpp to WTF::Function.

Landed in r219885: <http://trac.webkit.org/r219885>.