RESOLVED FIXED 174696
Create regression tests for the JIT probe. 
https://bugs.webkit.org/show_bug.cgi?id=174696
Summary Create regression tests for the JIT probe.
Mark Lam
Reported 2017-07-20 16:18:54 PDT
We should test that: 1. the probe is able to read the value of all CPU registers. 2. the probe is able to write the value of all CPU registers. 3. special case of (2): the probe is able to change the value of the stack pointer. 4. special case of (2): the probe is able to change the value of the program counter (where to execute upon returning from the probe). <rdar://problem/33436922>
Attachments
work in progress. (32.54 KB, patch)
2017-07-21 17:34 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch. (34.59 KB, patch)
2017-07-21 21:43 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2017-07-21 17:34:10 PDT
Created attachment 316149 [details] work in progress. This patch already passes the probe masm tests on x86, x86_64, and ARMv7. ARM64 won't pass the tests until we fix https://bugs.webkit.org/show_bug.cgi?id=174697. Still need to add fpr registers to the tests.
Mark Lam
Comment 2 2017-07-21 21:43:04 PDT
Created attachment 316168 [details] proposed patch.
Saam Barati
Comment 3 2017-07-23 11:41:34 PDT
Comment on attachment 316168 [details] proposed patch. Nice. r=me
Mark Lam
Comment 4 2017-07-23 13:06:35 PDT
Comment on attachment 316168 [details] proposed patch. Thanks for the review.
WebKit Commit Bot
Comment 5 2017-07-23 13:35:06 PDT
Comment on attachment 316168 [details] proposed patch. Clearing flags on attachment: 316168 Committed r219790: <http://trac.webkit.org/changeset/219790>
WebKit Commit Bot
Comment 6 2017-07-23 13:35:08 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 7 2017-07-24 03:18:58 PDT
(In reply to WebKit Commit Bot from comment #5) > Comment on attachment 316168 [details] > proposed patch. > > Clearing flags on attachment: 316168 > > Committed r219790: <http://trac.webkit.org/changeset/219790> It broke the CLOOP build, see build.webkit.org for details.
Mark Lam
Comment 8 2017-07-24 07:47:27 PDT
(In reply to Csaba Osztrogonác from comment #7) > (In reply to WebKit Commit Bot from comment #5) > > Comment on attachment 316168 [details] > > proposed patch. > > > > Clearing flags on attachment: 316168 > > > > Committed r219790: <http://trac.webkit.org/changeset/219790> > > It broke the CLOOP build, see build.webkit.org for details. Thanks for the report. Fix landed in r219821: <http://trac.webkit.org/r219821>.
Note You need to log in before you can comment on or make changes to this bug.