Bug 174694 - Refactor MASM probe CPUState to use arrays for register storage.
Summary: Refactor MASM probe CPUState to use arrays for register storage.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks: 174645
  Show dependency treegraph
 
Reported: 2017-07-20 15:53 PDT by Mark Lam
Modified: 2017-07-21 13:44 PDT (History)
8 users (show)

See Also:


Attachments
work in progress. (99.89 KB, patch)
2017-07-20 16:40 PDT, Mark Lam
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (9.98 MB, application/zip)
2017-07-20 21:14 PDT, Build Bot
no flags Details
proposed patch. (105.35 KB, patch)
2017-07-21 12:01 PDT, Mark Lam
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2017-07-20 15:53:12 PDT
This patch aims to:
1. Remove the need for macros for defining the list of CPU registers.
2. Make the assembler the authority on register names.
3. make the assembler the authority on the number of registers of each type.
Comment 1 Mark Lam 2017-07-20 16:40:49 PDT
Created attachment 316041 [details]
work in progress.
Comment 2 Build Bot 2017-07-20 16:43:20 PDT
Attachment 316041 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/assembler/ARM64Assembler.h:218:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/assembler/ARM64Assembler.h:227:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/assembler/ARM64Assembler.h:236:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2017-07-20 21:14:06 PDT
Comment on attachment 316041 [details]
work in progress.

Attachment 316041 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4158923

New failing tests:
imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html
Comment 4 Build Bot 2017-07-20 21:14:08 PDT
Created attachment 316067 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 5 Mark Lam 2017-07-21 12:01:39 PDT
Created attachment 316107 [details]
proposed patch.
Comment 6 Keith Miller 2017-07-21 12:16:57 PDT
Comment on attachment 316107 [details]
proposed patch.

r=me.
Comment 7 Mark Lam 2017-07-21 13:17:19 PDT
Comment on attachment 316107 [details]
proposed patch.

Thanks for the review.
Comment 8 WebKit Commit Bot 2017-07-21 13:44:37 PDT
Comment on attachment 316107 [details]
proposed patch.

Clearing flags on attachment: 316107

Committed r219740: <http://trac.webkit.org/changeset/219740>
Comment 9 WebKit Commit Bot 2017-07-21 13:44:39 PDT
All reviewed patches have been landed.  Closing bug.