When moving stuff from ResourceHandleManager to ResourceHandle on https://bugs.webkit.org/show_bug.cgi?id=173630, still there're many violation remains between ResourceHandle and ResourceHandleInternal classes. Many of implementation detail should be move to ResourceHandleInternal to improve build speed.
Created attachment 315824 [details] PATCH Just moved to hide implementation from public.
Comment on attachment 315824 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=315824&action=review I don't think ResourceHandleInternal should've ever been separated from ResourceHandle. They should've been one class. Keep in mind, the end goal is to have all this networking code work with the NetworkDataTask abstraction. Carlos Garcia did something similar with lib soup in these bugs, which were very heavily based on the asynchronous ResourceHandle work. https://bugs.webkit.org/show_bug.cgi?id=163597 https://bugs.webkit.org/show_bug.cgi?id=163777 https://bugs.webkit.org/show_bug.cgi?id=163939 > Source/WebCore/platform/network/ResourceHandleInternal.h:92 > + , m_handle { loader } Ideally a ResourceHandleInternal wouldn't need to store a pointer to its ResourceHandle, but whatevs.
Comment on attachment 315824 [details] PATCH Clearing flags on attachment: 315824 Committed r219630: <http://trac.webkit.org/changeset/219630>
All reviewed patches have been landed. Closing bug.
> I don't think ResourceHandleInternal should've ever been separated from > ResourceHandle. They should've been one class. Again, please think this to improve the speed of further implementation. Build time it currently issue for productivity. > Keep in mind, the end goal is to have all this networking code work with the > NetworkDataTask abstraction. Carlos Garcia did something similar with lib > soup in these bugs, which were very heavily based on the asynchronous > ResourceHandle work. > https://bugs.webkit.org/show_bug.cgi?id=163597 > https://bugs.webkit.org/show_bug.cgi?id=163777 > https://bugs.webkit.org/show_bug.cgi?id=163939 I'll check them. > > Source/WebCore/platform/network/ResourceHandleInternal.h:92 > > + , m_handle { loader } > > Ideally a ResourceHandleInternal wouldn't need to store a pointer to its > ResourceHandle, but whatevs. Thanks for understanding. We remove that pretty soon.