Bug 173630 - [Curl] ResourceHandleManager violate the class responsibility of ResourceHandle
Summary: [Curl] ResourceHandleManager violate the class responsibility of ResourceHandle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
URL:
Keywords:
Depends on: 173629
Blocks: 117300 173963 173964
  Show dependency tree / graph
 
Reported: 2017-06-20 17:40 PDT by Basuke Suzuki
Modified: 2017-06-29 14:59 PDT (History)
7 users (show)

See Also:

Attachments
Refactoring (69.48 KB, patch)
2017-06-29 14:18 PDT, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2017-06-20 17:40:16 PDT 
ResourceHandleManager directly manipulates the ResourceHandle contents, but it should be moved into ResourceHandle and ResourceHandleInternal by themselves.
Comment 1 Basuke Suzuki 2017-06-29 14:18:20 PDT 
Created attachment 314164 [details]
Refactoring

This patch is simply move methods and functions from ResourceHandleManager to ResourceHandle if possible. ResourceHandleManager apparently violent the class policy and it takes care of ResourceHandle too much which prevents to improve its own responsibility, which is managing ResourceHandle well.
Comment 2 WebKit Commit Bot 2017-06-29 14:58:59 PDT 
Comment on attachment 314164 [details]
Refactoring

Clearing flags on attachment: 314164

Committed r218962: <http://trac.webkit.org/changeset/218962>
Comment 3 WebKit Commit Bot 2017-06-29 14:59:00 PDT 
All reviewed patches have been landed.  Closing bug.