In bug #174545, Konstantin points out: "FWIW, raising requirement to 3.1 would allow us to use target_sources command, that can enable us to make target-specific setup in PlatformXXX.cmake files (now all such code has to be in shared CMakeLists.txt files)" We should do it.
I'm not going to work on this one now, but I figured I might as well file the bug now, so we don't forget to do it. It will be a nice cleanup. We can split more backend files to secondary cmake files at the same time, to avoid e.g. having a list of the same files to compile in both PlatformGTK.cmake and PlatformWPE.cmake.
Created attachment 315617 [details] Patch
Comment on attachment 315617 [details] Patch Attachment 315617 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4131971 New failing tests: security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.html
Created attachment 315622 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 315623 [details] Patch
Comment on attachment 315623 [details] Patch Attachment 315623 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4132526 New failing tests: imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html http/tests/cache/disk-cache/speculative-validation/cacheable-redirect.html
Created attachment 315631 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Comment on attachment 315623 [details] Patch Is this just step one? What is the advantage of doing this?
Advantage is that commands that operate on targets can now be used in PlatformXXX.cmake files
Comment on attachment 315623 [details] Patch Clearing flags on attachment: 315623 Committed r219560: <http://trac.webkit.org/changeset/219560>
All reviewed patches have been landed. Closing bug.