Bug 174545 - [CMake] Raise minimum CMake requirement
Summary: [CMake] Raise minimum CMake requirement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-15 10:14 PDT by Michael Catanzaro
Modified: 2017-07-16 07:28 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.88 KB, patch)
2017-07-15 20:53 PDT, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2017-07-15 10:14:19 PDT 
We can raise our CMake required version now, and remove some old code.
Comment 1 Konstantin Tokarev 2017-07-15 13:33:23 PDT 
FWIW, raising requirement to 3.1 would allow us to use target_sources command, that can enable us to make target-specific setup in PlatformXXX.cmake files (now all such code has to be in shared CMakeLists.txt files)
Comment 2 Michael Catanzaro 2017-07-15 20:49:18 PDT 
We can go as high as 3.5 (Ubuntu 16.04). Let's stick with 3.3 for now, though. That was the version I was planning to upgrade to to get access to a new generator expression. Turns out I won't be using it after all... but it's also the minimum version needed to remove all of our CMake version conditionals. So why not?

Using target_sources will be a great next step.

Note this will break our Debian stable bot, but that's due to be upgraded to Stretch anyway.
Comment 3 Michael Catanzaro 2017-07-15 20:53:02 PDT 
Created attachment 315586 [details]
Patch
Comment 4 WebKit Commit Bot 2017-07-16 07:28:16 PDT 
Comment on attachment 315586 [details]
Patch

Clearing flags on attachment: 315586

Committed r219547: <http://trac.webkit.org/changeset/219547>
Comment 5 WebKit Commit Bot 2017-07-16 07:28:18 PDT 
All reviewed patches have been landed.  Closing bug.