We can raise our CMake required version now, and remove some old code.
FWIW, raising requirement to 3.1 would allow us to use target_sources command, that can enable us to make target-specific setup in PlatformXXX.cmake files (now all such code has to be in shared CMakeLists.txt files)
We can go as high as 3.5 (Ubuntu 16.04). Let's stick with 3.3 for now, though. That was the version I was planning to upgrade to to get access to a new generator expression. Turns out I won't be using it after all... but it's also the minimum version needed to remove all of our CMake version conditionals. So why not?
Using target_sources will be a great next step.
Note this will break our Debian stable bot, but that's due to be upgraded to Stretch anyway.
Created attachment 315586 [details]
Comment on attachment 315586 [details]
Clearing flags on attachment: 315586
Committed r219547: <http://trac.webkit.org/changeset/219547>
All reviewed patches have been landed. Closing bug.