I'm thinking of moving the "Clock" to PAL https://bugs.webkit.org/show_bug.cgi?id=174342 but it has a dependency onto CoreMediaSoftLink. CoreMediaSoftLink and other SoftLink sources need to be moved to PAL in advance.
I'm wondering where CoreMediaSoftLink.* should go under "PAL/pal" as various platform sources depend on it and it doesn't seem to belong to a single component (such as File or Clock or whatever)
(In reply to Yoshiaki Jitsukawa from comment #1) > I'm wondering where CoreMediaSoftLink.* should go under "PAL/pal" as various > platform sources depend on it and it doesn't seem to belong to a single > component (such as File or Clock or whatever) It should go under PAL/pal.
For WebCore/platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h for example, which is appropriate? PAL/pal/cf/AVFoundationCFSoftLinking.h PAL/pal/platform/cf/AVFoundationCFSoftLinking.h PAL/pal/platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h or somewhere else?
Created attachment 320068 [details] WIP Patch
Attachment 320068 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/cocoa/CoreVideoSoftLink.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/PAL/pal/cocoa/CoreVideoSoftLink.cpp:43: Missing space after , [whitespace/comma] [3] ERROR: Source/WebCore/PAL/pal/PALPrefix.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebCore/PAL/pal/cf/MediaAccessibilitySoftLink.h:25: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/PAL/pal/CMakeLists.txt:30: One space between command "endif" and its parentheses, should be "endif (" [whitespace/parentheses] [5] Total errors found: 5 in 69 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 320069 [details] WIP Patch
Some SoftLink files seem to depend on the WebCorePrefix.h. It'll need PALPrefix.h to move these files into PAL.
CoreMediaSoftLink has already been introduced into PAL and we should add some other on demand. Closing.