Bug 174342 - [PAL] Move Clock into PAL
Summary: [PAL] Move Clock into PAL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-10 19:43 PDT by Yoshiaki Jitsukawa
Modified: 2017-09-27 12:50 PDT (History)
5 users (show)

See Also:

Attachments
Just checking if PlatformClockCA is used (466 bytes, patch)
2017-09-25 15:50 PDT, Yoshiaki Jitsukawa 		no flags Details | Formatted Diff | Diff
Patch (62.46 KB, patch)
2017-09-25 22:45 PDT, Yoshiaki Jitsukawa 		no flags Details | Formatted Diff | Diff
Patch (62.90 KB, patch)
2017-09-25 23:05 PDT, Yoshiaki Jitsukawa 		no flags Details | Formatted Diff | Diff
Patch (62.99 KB, patch)
2017-09-26 00:12 PDT, Yoshiaki Jitsukawa 		no flags Details | Formatted Diff | Diff
Patch (62.99 KB, patch)
2017-09-26 00:15 PDT, Yoshiaki Jitsukawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yoshiaki Jitsukawa 2017-07-10 19:43:23 PDT 
Move the following files to PAL:
 Clock.cpp
 Clock.h
 ClockGeneric.cpp
 ClockGeneric.h
 mac/PlatformClockCA.cpp
 mac/PlatformClockCA.h
 mac/PlatformClockCM.h
 mac/PlatformClockCM.mm
Comment 1 Yoshiaki Jitsukawa 2017-09-25 15:50:14 PDT 
Created attachment 321759 [details]
Just checking if PlatformClockCA is used
Comment 2 Yoshiaki Jitsukawa 2017-09-25 22:45:33 PDT 
Created attachment 321796 [details]
Patch
Comment 3 Yoshiaki Jitsukawa 2017-09-25 23:05:09 PDT 
Created attachment 321797 [details]
Patch
Comment 4 Myles C. Maxfield 2017-09-25 23:37:55 PDT 
Comment on attachment 321797 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321797&action=review

> Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.cpp:36
> +SOFT_LINK_FUNCTION_FOR_SOURCE(PAL, CoreMedia, CMTimeGetSeconds, Float64, (CMTime time), (time))

Why are these necessary?
Comment 5 Yoshiaki Jitsukawa 2017-09-25 23:57:02 PDT 
(In reply to Myles C. Maxfield from comment #4)
> Comment on attachment 321797 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=321797&action=review
> 
> > Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.cpp:36
> > +SOFT_LINK_FUNCTION_FOR_SOURCE(PAL, CoreMedia, CMTimeGetSeconds, Float64, (CMTime time), (time))
> 
> Why are these necessary?

These are required for mac 32 bit so I imported them from WebCore's 
CoreMediaSoftLink but looks like some more is needed to fix windows build.
Comment 6 Yoshiaki Jitsukawa 2017-09-26 00:11:41 PDT 
I needed to guard them with #if PLATFORM(COCOA)
Comment 7 Yoshiaki Jitsukawa 2017-09-26 00:12:47 PDT 
Created attachment 321802 [details]
Patch
Comment 8 Yoshiaki Jitsukawa 2017-09-26 00:15:09 PDT 
Created attachment 321804 [details]
Patch
Comment 9 WebKit Commit Bot 2017-09-26 12:57:34 PDT 
Comment on attachment 321804 [details]
Patch

Clearing flags on attachment: 321804

Committed r222515: <http://trac.webkit.org/changeset/222515>
Comment 10 WebKit Commit Bot 2017-09-26 12:57:36 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2017-09-27 12:50:49 PDT 
<rdar://problem/34694133>