RESOLVED FIXED 174342
[PAL] Move Clock into PAL 
https://bugs.webkit.org/show_bug.cgi?id=174342
Summary [PAL] Move Clock into PAL
Yoshiaki Jitsukawa
Reported 2017-07-10 19:43:23 PDT
Move the following files to PAL: Clock.cpp Clock.h ClockGeneric.cpp ClockGeneric.h mac/PlatformClockCA.cpp mac/PlatformClockCA.h mac/PlatformClockCM.h mac/PlatformClockCM.mm
Attachments
Just checking if PlatformClockCA is used (466 bytes, patch)
2017-09-25 15:50 PDT, Yoshiaki Jitsukawa 		no flags
DetailsFormatted DiffDiff
Patch (62.46 KB, patch)
2017-09-25 22:45 PDT, Yoshiaki Jitsukawa 		no flags
DetailsFormatted DiffDiff
Patch (62.90 KB, patch)
2017-09-25 23:05 PDT, Yoshiaki Jitsukawa 		no flags
DetailsFormatted DiffDiff
Patch (62.99 KB, patch)
2017-09-26 00:12 PDT, Yoshiaki Jitsukawa 		no flags
DetailsFormatted DiffDiff
Patch (62.99 KB, patch)
2017-09-26 00:15 PDT, Yoshiaki Jitsukawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Yoshiaki Jitsukawa
Comment 1 2017-09-25 15:50:14 PDT
Created attachment 321759 [details] Just checking if PlatformClockCA is used
Yoshiaki Jitsukawa
Comment 2 2017-09-25 22:45:33 PDT
Created attachment 321796 [details] Patch
Yoshiaki Jitsukawa
Comment 3 2017-09-25 23:05:09 PDT
Created attachment 321797 [details] Patch
Myles C. Maxfield
Comment 4 2017-09-25 23:37:55 PDT
Comment on attachment 321797 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321797&action=review > Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.cpp:36 > +SOFT_LINK_FUNCTION_FOR_SOURCE(PAL, CoreMedia, CMTimeGetSeconds, Float64, (CMTime time), (time)) Why are these necessary?
Yoshiaki Jitsukawa
Comment 5 2017-09-25 23:57:02 PDT
(In reply to Myles C. Maxfield from comment #4) > Comment on attachment 321797 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=321797&action=review > > > Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.cpp:36 > > +SOFT_LINK_FUNCTION_FOR_SOURCE(PAL, CoreMedia, CMTimeGetSeconds, Float64, (CMTime time), (time)) > > Why are these necessary? These are required for mac 32 bit so I imported them from WebCore's CoreMediaSoftLink but looks like some more is needed to fix windows build.
Yoshiaki Jitsukawa
Comment 6 2017-09-26 00:11:41 PDT
I needed to guard them with #if PLATFORM(COCOA)
Yoshiaki Jitsukawa
Comment 7 2017-09-26 00:12:47 PDT
Created attachment 321802 [details] Patch
Yoshiaki Jitsukawa
Comment 8 2017-09-26 00:15:09 PDT
Created attachment 321804 [details] Patch
WebKit Commit Bot
Comment 9 2017-09-26 12:57:34 PDT
Comment on attachment 321804 [details] Patch Clearing flags on attachment: 321804 Committed r222515: <http://trac.webkit.org/changeset/222515>
WebKit Commit Bot
Comment 10 2017-09-26 12:57:36 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2017-09-27 12:50:49 PDT
<rdar://problem/34694133>
Note You need to log in before you can comment on or make changes to this bug.