Bug 174246 – Speedometer 2.0: Fix deleting items in vanilla JS example

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mathias Bynens]

In the vanilla JS example, removing items doesn’t work: http://browserbench.org/Speedometer2.0/resources/todomvc/vanilla-examples/vanillajs/index.html

I’ll submit a CL for this.

[Mathias Bynens]

Created attachment 314822 [details]
Patch

[Build Bot]

Comment on attachment 314822 [details]
Patch

Attachment 314822 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4068870

New failing tests:
fast/workers/dedicated-worker-lifecycle.html

[Build Bot]

Created attachment 314823 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Ryosuke Niwa]

Comment on attachment 314822 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314822&action=review

Please fix the format of the change log entry.

> PerformanceTests/ChangeLog:8
> +        https://bugs.webkit.org/show_bug.cgi?id=174246

This line should appear immediately below the bug title.

> PerformanceTests/ChangeLog:10
> +        Reviewed by NOBODY (OOPS!).

Followed by this line, and then the description.

[Mathias Bynens]

Created attachment 314824 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 314824 [details]
Patch

Great. Thanks for the fix!

In the future, please also set cq (commit-queue) to ?
so that reviewers & committers can land your patch via the commit queue.

[Mathias Bynens]

Thanks for the quick turnaround on this!

Re: cq?, is there a way to tell `webkit-patch upload` to do that?

[WebKit Commit Bot]

Comment on attachment 314824 [details]
Patch

Clearing flags on attachment: 314824

Committed r219251: <http://trac.webkit.org/changeset/219251>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryosuke Niwa]

(In reply to Mathias Bynens from comment #7)
> Thanks for the quick turnaround on this!
> 
> Re: cq?, is there a way to tell `webkit-patch upload` to do that?

webkit-patch upload --commit-queue would do.

[Mathias Bynens]

> webkit-patch upload --commit-queue would do.

$ webkit-patch upload --commit-queue
Usage: webkit-patch [options] COMMAND [ARGS]

webkit-patch: error: no such option: --commit-queue

Type "webkit-patch --help" to see usage.

[Ryosuke Niwa]

(In reply to Mathias Bynens from comment #11)
> > webkit-patch upload --commit-queue would do.
> 
> $ webkit-patch upload --commit-queue
> Usage: webkit-patch [options] COMMAND [ARGS]
> 
> webkit-patch: error: no such option: --commit-queue
> 
> Type "webkit-patch --help" to see usage.

Oops, it would be webkit-patch upload --request-commit