RESOLVED DUPLICATE of bug 174149173970
enum constant CSSValueOblique in boolean context in CSSFontStyleValue.h 
https://bugs.webkit.org/show_bug.cgi?id=173970
Summary enum constant CSSValueOblique in boolean context in CSSFontStyleValue.h
Sander Mathijs van Veen
Reported 2017-06-29 08:58:34 PDT
I saw a compiler warning that looks like a typo and can cause a problem. /home/smvv/work/jhbuild/checkout/webkitgtk-2.17.4/Source/WebCore/css/CSSFontStyleValue.h: In member function ‘bool WebCore::CSSFontStyleValue::isItalic() const’: /home/smvv/work/jhbuild/checkout/webkitgtk-2.17.4/Source/WebCore/css/CSSFontStyleValue.h:53:49: warning: enum constant in boolean context [-Wint-in-bool-context] return valueID == CSSValueItalic || CSSValueOblique; ^~~~~~~~~~~~~~~ A fix would be: return valueID == CSSValueItalic || valueID == CSSValueOblique;
Attachments
Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2022-07-15 11:07:10 PDT
It looks like Myles picked this fix up in Bug 174149. *** This bug has been marked as a duplicate of bug 174149 ***
Note You need to log in before you can comment on or make changes to this bug.