Bug 173970 - enum constant CSSValueOblique in boolean context in CSSFontStyleValue.h
Summary: enum constant CSSValueOblique in boolean context in CSSFontStyleValue.h
Status: RESOLVED DUPLICATE of bug 174149
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 169258
Blocks:
  Show dependency tree / graph
 
Reported: 2017-06-29 08:58 PDT by Sander Mathijs van Veen
Modified: 2022-07-15 11:07 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sander Mathijs van Veen 2017-06-29 08:58:34 PDT 
I saw a compiler warning that looks like a typo and can cause a problem.

/home/smvv/work/jhbuild/checkout/webkitgtk-2.17.4/Source/WebCore/css/CSSFontStyleValue.h: In member function ‘bool WebCore::CSSFontStyleValue::isItalic() const’:
/home/smvv/work/jhbuild/checkout/webkitgtk-2.17.4/Source/WebCore/css/CSSFontStyleValue.h:53:49: warning: enum constant in boolean context [-Wint-in-bool-context]
             return valueID == CSSValueItalic || CSSValueOblique;
                                                 ^~~~~~~~~~~~~~~

A fix would be:

             return valueID == CSSValueItalic || valueID == CSSValueOblique;
Comment 1 Brent Fulgham 2022-07-15 11:07:10 PDT 
It looks like Myles picked this fix up in Bug 174149.

*** This bug has been marked as a duplicate of bug 174149 ***