Bug 169258 - font-style needs a new CSSValue to make CSSRule.cssText work correctly
Summary: font-style needs a new CSSValue to make CSSRule.cssText work correctly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks: 162815 173970
  Show dependency treegraph
 
Reported: 2017-03-06 21:07 PST by Myles C. Maxfield
Modified: 2017-06-29 08:59 PDT (History)
9 users (show)

See Also:


Attachments
Patch (29.14 KB, patch)
2017-03-23 00:50 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews114 for mac-elcapitan (1.11 MB, application/zip)
2017-03-23 02:04 PDT, Build Bot
no flags Details
Patch (83.43 KB, patch)
2017-03-23 15:31 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1021.55 KB, application/zip)
2017-03-23 16:32 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (993.63 KB, application/zip)
2017-03-23 17:11 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews114 for mac-elcapitan (1.95 MB, application/zip)
2017-03-23 17:14 PDT, Build Bot
no flags Details
WIP (85.94 KB, patch)
2017-03-23 17:33 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (87.26 KB, patch)
2017-03-23 23:02 PDT, Myles C. Maxfield
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2017-03-06 21:07:18 PST
A new subclass is necessary to make the "oblique" keyword show up in the cssText.
Comment 1 Myles C. Maxfield 2017-03-07 17:17:26 PST
Also because "oblique" and "italic" probably should result in different variation axes being used.
Comment 2 Myles C. Maxfield 2017-03-07 17:21:37 PST
See also: https://github.com/w3c/csswg-drafts/issues/1085
Comment 3 Myles C. Maxfield 2017-03-23 00:50:24 PDT
Created attachment 305174 [details]
Patch
Comment 4 Build Bot 2017-03-23 02:04:38 PDT
Comment on attachment 305174 [details]
Patch

Attachment 305174 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3393453

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2017-03-23 02:04:40 PDT
Created attachment 305178 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Myles C. Maxfield 2017-03-23 15:31:18 PDT
Created attachment 305230 [details]
Patch
Comment 7 Build Bot 2017-03-23 16:32:30 PDT
Comment on attachment 305230 [details]
Patch

Attachment 305230 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3398371

New failing tests:
editing/execCommand/italicizeByCharacter.html
editing/execCommand/format-block-contenteditable-false.html
editing/execCommand/toggle-link-win.html
editing/execCommand/toggle-compound-styles.html
editing/style/toggle-style-bold-italic-mixed-editability.html
editing/execCommand/toggle-link-mac.html
fast/events/before-input-prevent-biu.html
editing/style/toggle-style-bold-italic.html
editing/execCommand/toggle-unlink-mac.html
editing/execCommand/toggle-style-3.html
editing/apply-style-iframe-crash.html
editing/style/typing-style-003.html
editing/style/push-down-inline-styles.html
editing/style/push-down-implicit-styles-around-list-mac.html
editing/style/style-3681552-fix-002.html
editing/style/remove-styled-element-with-style-span.html
editing/style/push-down-implicit-styles-around-list-win.html
editing/style/inline-style-extend-run.html
editing/style/style-text-node-without-editable-parent.html
Comment 8 Build Bot 2017-03-23 16:32:34 PDT
Created attachment 305240 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 9 Build Bot 2017-03-23 17:11:38 PDT
Comment on attachment 305230 [details]
Patch

Attachment 305230 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3398606

New failing tests:
editing/execCommand/italicizeByCharacter.html
editing/execCommand/format-block-contenteditable-false.html
editing/execCommand/toggle-compound-styles.html
editing/style/toggle-style-bold-italic-mixed-editability.html
editing/style/inline-style-extend-run.html
editing/execCommand/toggle-link-win.html
editing/style/toggle-style-bold-italic.html
editing/style/style-3681552-fix-002.html
editing/execCommand/toggle-style-3.html
editing/apply-style-iframe-crash.html
editing/style/typing-style-003.html
editing/style/push-down-inline-styles.html
editing/style/remove-styled-element-with-style-span.html
Comment 10 Build Bot 2017-03-23 17:11:40 PDT
Created attachment 305247 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 11 Build Bot 2017-03-23 17:14:48 PDT
Comment on attachment 305230 [details]
Patch

Attachment 305230 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3398743

New failing tests:
editing/execCommand/italicizeByCharacter.html
editing/execCommand/format-block-contenteditable-false.html
fast/events/before-input-prevent-biu.html
editing/style/toggle-style-bold-italic-mixed-editability.html
editing/execCommand/toggle-link-mac.html
editing/execCommand/toggle-link-win.html
editing/style/typing-style-003.html
editing/execCommand/toggle-unlink-mac.html
editing/execCommand/toggle-style-3.html
editing/apply-style-iframe-crash.html
editing/style/toggle-style-bold-italic.html
editing/style/push-down-inline-styles.html
editing/style/remove-styled-element-with-style-span.html
editing/style/push-down-implicit-styles-around-list-mac.html
editing/style/style-3681552-fix-002.html
editing/execCommand/toggle-compound-styles.html
editing/style/push-down-implicit-styles-around-list-win.html
editing/style/inline-style-extend-run.html
editing/style/style-text-node-without-editable-parent.html
Comment 12 Build Bot 2017-03-23 17:14:51 PDT
Created attachment 305248 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 13 Myles C. Maxfield 2017-03-23 17:33:01 PDT
Created attachment 305250 [details]
WIP
Comment 14 Myles C. Maxfield 2017-03-23 23:02:24 PDT
Created attachment 305268 [details]
Patch
Comment 15 Dave Hyatt 2017-03-24 10:59:59 PDT
Comment on attachment 305268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305268&action=review

r=me

> Source/WebCore/css/CSSFontStyleValue.h:30
> +#include "FontSelectionAlgorithm.h"

Don't think you need this include, right?

> Source/WebCore/css/CSSFontValue.cpp:48
> -    if (weight) {
> +    if (stretch) {

Hah!
Comment 16 Myles C. Maxfield 2017-03-24 11:23:01 PDT
Comment on attachment 305268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305268&action=review

>> Source/WebCore/css/CSSFontStyleValue.h:30
>> +#include "FontSelectionAlgorithm.h"
> 
> Don't think you need this include, right?

It's needed for italicValue()
Comment 17 Myles C. Maxfield 2017-03-24 11:23:58 PDT
Committed r214359: <http://trac.webkit.org/changeset/214359>