SSIA.
Created attachment 313591 [details] WIP patch
Attachment 313591 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 313828 [details] WIP patch
Attachment 313828 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 314030 [details] Patch
(In reply to Zan Dobersek from comment #5) > Created attachment 314030 [details] > Patch This is ready for review, but the patch still relies on libtasn1 helpers that are being added in bug #173646.
Created attachment 314463 [details] Patch Now buildable.
Comment on attachment 314463 [details] Patch Attachment 314463 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4043009 New failing tests: workers/bomb.html
Created attachment 314470 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 314463 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314463&action=review Looks good to me. r- because of duplicated functions. > Source/WebCore/crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:377 > + if (!PAL::TASN1::writeElement(pkcs8, "privateKeyAlgorithm.algorithm", "1.2.840.113549.1.1.1", 1)) Constant for "1.2.840.113549.1.1.1". > Source/WebCore/crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:381 > + if (!PAL::TASN1::writeElement(pkcs8, "privateKeyAlgorithm.parameters", "\x05\x00", 2)) Ditto for "\x05\x00". > Source/WebCore/crypto/gcrypt/GCryptUtilities.h:159 > +static inline std::optional<Vector<uint8_t>> mpiSignedData(gcry_mpi_t mpi) Remove these two duplicated function after Bug 173695 is resolved.
Created attachment 315340 [details] Patch
Comment on attachment 315340 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315340&action=review > Source/WebCore/crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:517 > + if (!PAL::TASN1::writeElement(pkcs8, "privateKeyAlgorithm.parameters", "\x05\x00", 2)) "\x05\x00" could be a constant. You can do it separately.
Comment on attachment 315340 [details] Patch Looks good to me. r=me.
Committed r219536: <http://trac.webkit.org/changeset/219536>