SSIA.
Created attachment 313588 [details] WIP patch
Attachment 313588 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 313827 [details] WIP patch
Attachment 313827 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 314028 [details] Patch
(In reply to Zan Dobersek from comment #5) > Created attachment 314028 [details] > Patch This is ready for review, but the patch still relies on libtasn1 helpers that are being added in bug #173646.
Created attachment 314462 [details] Patch Now buildable.
Comment on attachment 314462 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314462&action=review Looks good to me. r=me. > Source/WebCore/ChangeLog:29 > + A helper mpiSignedData() function is added, providing overloads for gcry_mpi_t Interesting. > Source/WebCore/crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:304 > + if (!PAL::TASN1::writeElement(spki, "algorithm.algorithm", "1.2.840.113549.1.1.1", 1)) Remember we should replace "1.2.840.113549.1.1.1" with a constant. > Source/WebCore/crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:308 > + if (!PAL::TASN1::writeElement(spki, "algorithm.parameters", "\x05\x00", 2)) Another constant here?
Committed r219449: <http://trac.webkit.org/changeset/219449>