Bug 173375 - REGRESSION (r218228): Layout Test editing/execCommand/strikethrough-uses-strike-tag.html is failing
Summary: REGRESSION (r218228): Layout Test editing/execCommand/strikethrough-uses-stri...
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-14 11:09 PDT by Matt Lewis
Modified: 2017-06-15 13:39 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Lewis 2017-06-14 11:09:33 PDT
editing/execCommand/strikethrough-uses-strike-tag.html started failing after revision r218228 https://trac.webkit.org/changeset/218228/webkit

I spoke with Zalan about the revision and failure. Test just needed re-baselining.
Comment 1 Matt Lewis 2017-06-14 11:12:58 PDT
Re-baselined test:
https://trac.webkit.org/changeset/218273/webkit
Comment 2 Matt Lewis 2017-06-14 12:20:55 PDT
Fixed typo:
https://trac.webkit.org/changeset/218279/webkit
Comment 3 Matt Lewis 2017-06-14 18:20:29 PDT
After the Re-baseline, the test began to pass on release, but the Debug builds began to fail.

Debug diff
--- /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/editing/execCommand/strikethrough-uses-strike-tag-expected.txt
+++ /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/editing/execCommand/strikethrough-uses-strike-tag-actual.txt
@@ -1,4 +1,3 @@
-Blocked access to external URL https://www.webkit.org/
 Ensuring we continue to use strike tags for legacy strikethrough execCommands, not s tags. See https://bugs.webkit.org/show_bug.cgi?id=53475
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Comment 4 Alexey Proskuryakov 2017-06-14 23:13:44 PDT
> -Blocked access to external URL https://www.webkit.org/

This output is coming from the preceding test editing/execCommand/show-modal-dialog-during-execCommand.html, which is now unskipped, but only in release.

Zalan, could you please take a look? Clearly, we shouldn't leak output from the preceding test.
Comment 5 zalan 2017-06-15 08:28:13 PDT
(In reply to Alexey Proskuryakov from comment #4)
> > -Blocked access to external URL https://www.webkit.org/
> 
> This output is coming from the preceding test
> editing/execCommand/show-modal-dialog-during-execCommand.html, which is now
> unskipped, but only in release.
> 
> Zalan, could you please take a look? Clearly, we shouldn't leak output from
> the preceding test.
Oh, I was under the impression that the unskipped test(show-modal-dialog-during-execCommand.html) needed rebaselining. I agree, it's not okay to leak output from any test. I will surely look at it though I am not the best person to deal with such failures.
Comment 6 Matt Lewis 2017-06-15 12:02:07 PDT
Spoke with zalan, reverted re-baseline and re-implemented skip. 
https://trac.webkit.org/changeset/218346/webkit