Created attachment 312812 [details]
see bug 173329 too.
Comment on attachment 312812 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=312812&action=review
> + // FIXME: Firing media query callbacks synchronously on nested frames could produced a detached FrameView here (webkit.org/b/173329).
I would mention that a media query listener could trigger a navigation.
Created attachment 312824 [details]
The commit-queue encountered the following flaky tests while processing attachment 312824 [details]:
media/media-source/media-source-unnecessary-seek-seeked.html bug 173344 (author: email@example.com)
The commit-queue is continuing to process your patch.
Comment on attachment 312824 [details]
Clearing flags on attachment: 312824
Committed r218228: <http://trac.webkit.org/changeset/218228>
All reviewed patches have been landed. Closing bug.
After this patch was added, the test editing/execCommand/strikethrough-uses-strike-tag.html started failing on release builds
Per Zalan, I Re-baselined the test. See bug: https://bugs.webkit.org/show_bug.cgi?id=173375
After the re-baseline, the test began to pass on release, but started to fail on Mac WK1 Debug.