Bug 173330 - Synchronous media query callbacks on nested frames could produced a detached FrameView.
Summary: Synchronous media query callbacks on nested frames could produced a detached ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
Keywords: InRadar
Depends on:
Reported: 2017-06-13 14:30 PDT by zalan
Modified: 2017-06-14 18:23 PDT (History)
5 users (show)

See Also:

Patch (3.14 KB, patch)
2017-06-13 14:45 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (3.19 KB, patch)
2017-06-13 16:08 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-06-13 14:30:15 PDT
Comment 1 zalan 2017-06-13 14:45:12 PDT
Created attachment 312812 [details]
Comment 2 zalan 2017-06-13 14:45:51 PDT
see bug 173329 too.
Comment 3 Simon Fraser (smfr) 2017-06-13 14:49:09 PDT
Comment on attachment 312812 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=312812&action=review

> Source/WebCore/page/FrameView.cpp:1522
> +        // FIXME: Firing media query callbacks synchronously on nested frames could produced a detached FrameView here (webkit.org/b/173329).

I would mention that a media query listener could trigger a navigation.
Comment 4 zalan 2017-06-13 16:08:50 PDT
Created attachment 312824 [details]
Comment 5 WebKit Commit Bot 2017-06-13 17:18:52 PDT
The commit-queue encountered the following flaky tests while processing attachment 312824 [details]:

media/media-source/media-source-unnecessary-seek-seeked.html bug 173344 (author: jer.noble@apple.com)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2017-06-13 17:19:25 PDT
Comment on attachment 312824 [details]

Clearing flags on attachment: 312824

Committed r218228: <http://trac.webkit.org/changeset/218228>
Comment 7 WebKit Commit Bot 2017-06-13 17:19:26 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Matt Lewis 2017-06-14 18:23:57 PDT
After this patch was added, the test editing/execCommand/strikethrough-uses-strike-tag.html started failing on release builds

Per Zalan, I Re-baselined the test. See bug: https://bugs.webkit.org/show_bug.cgi?id=173375

After the re-baseline, the test began to pass on release, but started to fail on Mac WK1 Debug.