Bug 173328 – [macOS El Capitan and Sierra] [iOS 10] The system Japanese font cannot be italicized

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: New Bugs

[Myles C. Maxfield]

[macOS El Capitan and Sierra] [iOS 10] The system Japanese font cannot be italicized

[Myles C. Maxfield]

Created attachment 312811 [details]
Patch

[Myles C. Maxfield]

Created attachment 312818 [details]
Patch

[Myles C. Maxfield]

Created attachment 312828 [details]
Patch

[Build Bot]

Comment on attachment 312828 [details]
Patch

Attachment 312828 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3926337

New failing tests:
imported/w3c/web-platform-tests/html/dom/reflection-grouping.html
js/intl-datetimeformat.html
js/kde/parse.html
imported/w3c/web-platform-tests/html/dom/reflection-obsolete.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/srcset/parse-a-srcset-attribute.html
imported/w3c/web-platform-tests/html/dom/reflection-tabular.html
fast/url/idna2003.html
imported/w3c/web-platform-tests/html/dom/reflection-embedded.html
editing/text-iterator/rtl-first-letter-text-iterator-crash.html
fast/text/crash-obscure-text.html
imported/w3c/web-platform-tests/html/dom/reflection-forms.html

[Build Bot]

Created attachment 312842 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 312828 [details]
Patch

Attachment 312828 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3926894

New failing tests:
js/intl-datetimeformat.html
js/kde/parse.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/srcset/parse-a-srcset-attribute.html
fast/url/idna2003.html
editing/text-iterator/rtl-first-letter-text-iterator-crash.html
fast/text/crash-obscure-text.html

[Build Bot]

Created attachment 312854 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Myles C. Maxfield]

*** This bug has been marked as a duplicate of bug 173300 ***

[Daniel Bates]

Comment on attachment 312828 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312828&action=review

Is this patch still relevant? If it is then do you want to rebase it? If it isn’t then you want to close this bug? Patch contains too much magic for me.

> Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:87
> +    if (weight >= FontSelectionValue(350)) {

Where is the magic number 350 coming from? What is the range we’re working with?

> Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:90
> +    } else if (weight >= FontSelectionValue(250))

Such magic.

> Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:92
> +    else if (weight >= FontSelectionValue(150))

Magic

> Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:102
> +    RetainPtr<NSMutableDictionary> traitsDictionary = adoptNS([[NSMutableDictionary alloc] init]);

auto

> Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:123
> +    [traitsDictionary setObject:[NSNumber numberWithFloat:ctWeight] forKey:static_cast<NSString *>(kCTFontWeightTrait)];

@(ctWeight)? @(kCT...)?

> Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:128
> +        [traitsDictionary setObject:[NSNumber numberWithInt:kCTFontItalicTrait] forKey:static_cast<NSString *>(kCTFontSymbolicTrait)];

Similar questions, can we use literal syntax to simplify?

> Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:130
> +    return @{ static_cast<NSString *>(kCTFontTraitsAttribute) : traitsDictionary.get() };

Can we use this syntax for all the unconditional items added to the dictionary and then that just leaves special handing for italic?