Bug 173300 - [Cocoa] The system Japanese font cannot be italicized
Summary: [Cocoa] The system Japanese font cannot be italicized
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
: 173328 (view as bug list)
Depends on: 173328
Blocks:
  Show dependency tree / graph
 
Reported: 2017-06-12 21:58 PDT by Myles C. Maxfield
Modified: 2017-06-20 16:52 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.12 KB, patch)
2017-06-12 22:05 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
WIP (6.11 KB, patch)
2017-06-12 23:02 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (6.14 KB, patch)
2017-06-13 00:02 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (9.47 KB, patch)
2017-06-13 13:53 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (1.91 KB, patch)
2017-06-13 17:40 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (6.50 KB, patch)
2017-06-15 18:23 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-elcapitan (1.80 MB, application/zip)
2017-06-15 19:26 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews117 for mac-elcapitan (2.29 MB, application/zip)
2017-06-15 19:37 PDT, Build Bot 		no flags Details
Patch (6.37 KB, patch)
2017-06-16 16:40 PDT, Myles C. Maxfield 		rniwa: review+
Details | Formatted Diff | Diff
Patch for committing (6.45 KB, patch)
2017-06-16 17:03 PDT, Myles C. Maxfield 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-elcapitan (1.71 MB, application/zip)
2017-06-16 18:24 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews114 for mac-elcapitan (2.20 MB, application/zip)
2017-06-16 18:35 PDT, Build Bot 		no flags Details
Patch for committing (7.27 KB, patch)
2017-06-19 17:34 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (11) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2017-06-12 21:58:43 PDT 
[Cocoa] The system Japanese font cannot be italicized
Comment 1 Myles C. Maxfield 2017-06-12 22:05:44 PDT 
Created attachment 312749 [details]
Patch
Comment 2 Myles C. Maxfield 2017-06-12 22:06:10 PDT 
<rdar://problem/31805407>
Comment 3 Myles C. Maxfield 2017-06-12 23:02:56 PDT 
Created attachment 312752 [details]
WIP
Comment 4 Myles C. Maxfield 2017-06-13 00:02:20 PDT 
Created attachment 312755 [details]
Patch
Comment 5 Myles C. Maxfield 2017-06-13 13:53:43 PDT 
Created attachment 312804 [details]
Patch
Comment 6 Myles C. Maxfield 2017-06-13 17:40:56 PDT 
Created attachment 312838 [details]
Patch
Comment 7 Myles C. Maxfield 2017-06-15 18:20:11 PDT 
*** Bug 173328 has been marked as a duplicate of this bug. ***
Comment 8 Myles C. Maxfield 2017-06-15 18:23:26 PDT 
Created attachment 313040 [details]
Patch
Comment 9 Build Bot 2017-06-15 19:26:04 PDT 
Comment on attachment 313040 [details]
Patch

Attachment 313040 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3938886

New failing tests:
imported/w3c/web-platform-tests/html/dom/reflection-grouping.html
js/intl-datetimeformat.html
js/kde/parse.html
imported/w3c/web-platform-tests/html/dom/reflection-obsolete.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/srcset/parse-a-srcset-attribute.html
imported/w3c/web-platform-tests/html/dom/reflection-tabular.html
fast/url/idna2003.html
imported/w3c/web-platform-tests/html/dom/reflection-embedded.html
editing/text-iterator/rtl-first-letter-text-iterator-crash.html
fast/text/crash-obscure-text.html
imported/w3c/web-platform-tests/html/dom/reflection-forms.html
Comment 10 Build Bot 2017-06-15 19:26:05 PDT 
Created attachment 313047 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 11 Build Bot 2017-06-15 19:37:18 PDT 
Comment on attachment 313040 [details]
Patch

Attachment 313040 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3938892

New failing tests:
js/intl-datetimeformat.html
js/kde/parse.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/srcset/parse-a-srcset-attribute.html
fast/url/idna2003.html
editing/text-iterator/rtl-first-letter-text-iterator-crash.html
fast/text/crash-obscure-text.html
Comment 12 Build Bot 2017-06-15 19:37:19 PDT 
Created attachment 313049 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 13 Myles C. Maxfield 2017-06-16 16:40:18 PDT 
Created attachment 313156 [details]
Patch
Comment 14 Ryosuke Niwa 2017-06-16 16:42:55 PDT 
Comment on attachment 313156 [details]
Patch

r=me assuming it passes tests.
Comment 15 Myles C. Maxfield 2017-06-16 17:03:05 PDT 
Created attachment 313160 [details]
Patch for committing
Comment 16 Build Bot 2017-06-16 18:24:50 PDT 
Comment on attachment 313160 [details]
Patch for committing

Attachment 313160 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3945012

New failing tests:
imported/w3c/web-platform-tests/html/dom/reflection-grouping.html
js/intl-datetimeformat.html
js/kde/parse.html
imported/w3c/web-platform-tests/html/dom/reflection-obsolete.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/srcset/parse-a-srcset-attribute.html
imported/w3c/web-platform-tests/html/dom/reflection-tabular.html
fast/url/idna2003.html
imported/w3c/web-platform-tests/html/dom/reflection-embedded.html
editing/text-iterator/rtl-first-letter-text-iterator-crash.html
fast/text/crash-obscure-text.html
imported/w3c/web-platform-tests/html/dom/reflection-forms.html
Comment 17 Build Bot 2017-06-16 18:24:51 PDT 
Created attachment 313172 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 18 Build Bot 2017-06-16 18:35:37 PDT 
Comment on attachment 313160 [details]
Patch for committing

Attachment 313160 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3945009

New failing tests:
js/intl-datetimeformat.html
js/kde/parse.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/srcset/parse-a-srcset-attribute.html
fast/url/idna2003.html
editing/text-iterator/rtl-first-letter-text-iterator-crash.html
fast/text/crash-obscure-text.html
Comment 19 Build Bot 2017-06-16 18:35:39 PDT 
Created attachment 313174 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 20 Myles C. Maxfield 2017-06-19 17:25:36 PDT 
It looks like there is no way to work around this crash in El Capitan. I'll add a platform guard.
Comment 21 Myles C. Maxfield 2017-06-19 17:34:13 PDT 
Created attachment 313346 [details]
Patch for committing
Comment 22 WebKit Commit Bot 2017-06-19 19:28:21 PDT 
Comment on attachment 313346 [details]
Patch for committing

Clearing flags on attachment: 313346

Committed r218524: <http://trac.webkit.org/changeset/218524>
Comment 23 Ryan Haddad 2017-06-20 16:22:22 PDT 
Reverted r218524 for reason:

This change broke internal builds.

Committed r218614: <http://trac.webkit.org/changeset/218614>
Comment 24 Myles C. Maxfield 2017-06-20 16:52:30 PDT 
Committed r218616: <http://trac.webkit.org/changeset/218616>