Bug 173277 - [iOS] Cmd-C doesn't copy text from WKWebView
Summary: [iOS] Cmd-C doesn't copy text from WKWebView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-12 14:46 PDT by Tim Horton
Modified: 2017-08-29 15:52 PDT (History)
7 users (show)

See Also:


Attachments
Patch (20.98 KB, patch)
2017-06-12 14:46 PDT, Tim Horton
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2017-06-12 14:46:30 PDT
[iOS] Cmd-C doesn't copy text from WKWebView
Comment 1 Tim Horton 2017-06-12 14:46:58 PDT
Created attachment 312699 [details]
Patch
Comment 2 Tim Horton 2017-06-12 14:50:31 PDT
rdar://problem/32396742
Comment 3 mitz 2017-06-12 15:05:52 PDT
Comment on attachment 312699 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312699&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewInternal.h:133
> +- (void)_addShortcut:(id)sender;
> +- (void)_arrowKey:(id)sender;
> +- (void)_define:(id)sender;
> +- (void)_lookup:(id)sender;
> +- (void)_reanalyze:(id)sender;
> +- (void)_share:(id)sender;
> +- (void)_showTextStyleOptions:(id)sender;
> +- (void)_promptForReplace:(id)sender;
> +- (void)_transliterateChinese:(id)sender;
> +- (void)replace:(id)sender;

Are these necessary?

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h:343
> +

?
Comment 4 Tim Horton 2017-06-12 15:27:00 PDT
Comment on attachment 312699 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312699&action=review

>> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewInternal.h:133
>> +- (void)replace:(id)sender;
> 
> Are these necessary?

I think so? I moved these here from WKContentViewInteraction. They're called from another file (WKContentViewInteraction.mm), and aren't in any header that we can always see.

>> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h:343
>> +
> 
> ?

Not a clue.
Comment 5 Tim Horton 2017-06-12 15:28:42 PDT
https://trac.webkit.org/changeset/218144/webkit
Comment 6 Matt Lewis 2017-06-12 17:42:40 PDT
I believe this revision https://trac.webkit.org/changeset/218144/webkit caused an api failure on iOS.
Comment 7 Tim Horton 2017-06-12 17:51:37 PDT
The API test doesn’t work? Works for me in the sim. I will investigate tomorrow.
Comment 8 Tim Horton 2017-06-14 10:09:00 PDT
Odd, running the test alone is fine, but running it with all the others causes it to fail.
Comment 9 Tim Horton 2017-06-14 10:14:07 PDT
That seems to not always be true, sometimes it times out alone too.
Comment 10 Tim Horton 2017-06-14 11:06:32 PDT
https://bugs.webkit.org/show_bug.cgi?id=173374 will fix the test
Comment 11 mitz 2017-08-29 15:52:21 PDT
(In reply to Tim Horton from comment #5)
> https://trac.webkit.org/changeset/218144/webkit

This caused bug 176077.