RESOLVED FIXED 173374
WKContentViewEditingActions API test always fails 
https://bugs.webkit.org/show_bug.cgi?id=173374
Summary WKContentViewEditingActions API test always fails
Tim Horton
Reported 2017-06-14 11:05:09 PDT
WKContentViewEditingActions API test always fails
Attachments
Patch (2.83 KB, patch)
2017-06-14 11:05 PDT, Tim Horton 		wenson_hsieh: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2017-06-14 11:05:46 PDT
Created attachment 312907 [details] Patch
Wenson Hsieh
Comment 2 2017-06-14 11:12:50 PDT
Comment on attachment 312907 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312907&action=review > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:70 > + if ([[[UIPasteboard generalPasteboard] string] isEqualToString:@"Hello world"]) Nit - could we make this always set done = true here, and then check that [[[UIPasteboard generalPasteboard] string] isEqualToString:@"Hello world"] after TestWebKitAPI::Util::run(&done) using EXPECT_WK_STREQ? This way, if the strings don't match, it'll print out the expected vs. observed values instead of timing out.
Tim Horton
Comment 3 2017-06-14 11:20:07 PDT
Seems reasonable!
Tim Horton
Comment 4 2017-06-14 11:22:53 PDT
https://trac.webkit.org/changeset/218276/webkit
Note You need to log in before you can comment on or make changes to this bug.