Bug 173197 – [WebCrypto] Remove experimental feature flag of SubtleCrypto

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Jiewen Tan]

Remove experimental feature flag.

[Radar WebKit Bug Importer]

<rdar://problem/32688148>

[Jiewen Tan]

Created attachment 312523 [details]
Patch

[Jiewen Tan]

Created attachment 312524 [details]
Patch

[Sam Weinig]

This patch does not contain a reason.

[Brent Fulgham]

Comment on attachment 312524 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312524&action=review

> Source/WebCore/ChangeLog:7
> +        Reviewed by NOBODY (OOPS!).

Please add a statement like "The SubtleCrypto implementation is no longer experimental and is ready for production use. We are therefore removing the runtime flag."

[Jiewen Tan]

Comment on attachment 312524 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312524&action=review

Thanks Brent for r+ my patch.

>> Source/WebCore/ChangeLog:7
>> +        Reviewed by NOBODY (OOPS!).
> 
> Please add a statement like "The SubtleCrypto implementation is no longer experimental and is ready for production use. We are therefore removing the runtime flag."

Fixed.

[Jiewen Tan]

Created attachment 312686 [details]
Patch for landing

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 312686 [details]:

imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-av-audio-bitrate.html bug 173270 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 312686 [details]
Patch for landing

Clearing flags on attachment: 312686

Committed r218129: <http://trac.webkit.org/changeset/218129>

[Michael Catanzaro]

Congrats Jiewen!

[Daniel Bates]

Comment on attachment 312524 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312524&action=review

> Source/WebCore/page/Crypto.idl:34
> +    [Conditional=SUBTLE_CRYPTO] readonly attribute SubtleCrypto subtle;

Would it be reasonable to mark this as SecureContext as per the spec.? Ideally, we would mark all WebCrypto API as SecureContext though I'm unclear if we can mark API associated with the deprecated webkitSubtle without breaking web compatibility.

[Michael Catanzaro]

Good catch.

Was webkitSubtle ever web exposed? Are we not able to just remove it?

[Jiewen Tan]

(In reply to Daniel Bates from comment #11)
> Comment on attachment 312524 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=312524&action=review
> 
> > Source/WebCore/page/Crypto.idl:34
> > +    [Conditional=SUBTLE_CRYPTO] readonly attribute SubtleCrypto subtle;
> 
> Would it be reasonable to mark this as SecureContext as per the spec.?
> Ideally, we would mark all WebCrypto API as SecureContext though I'm unclear
> if we can mark API associated with the deprecated webkitSubtle without
> breaking web compatibility.

We should mark this as SecureContext. See Bug 166959. For the webkitSubtle, I think we shouldn't.

[Jiewen Tan]

(In reply to Michael Catanzaro from comment #12)
> Good catch.
> 
> Was webkitSubtle ever web exposed? Are we not able to just remove it?

It is web exposed therefore I think we should gradually deprecate it.