Bug 173130 – Use WTF::getCurrentProcessID() instead of getpid().

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Daewoong Jang]

Use WTF::getCurrentProcessID() instead of getpid().

[Daewoong Jang]

Created attachment 312387 [details]
patch

[WebKit Commit Bot]

Comment on attachment 312387 [details]
patch

Clearing flags on attachment: 312387

Committed r217975: <http://trac.webkit.org/changeset/217975>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

Out of curiosity, what is the benefit of one over another here?

[Daewoong Jang]

(In reply to Alexey Proskuryakov from comment #4)
> Out of curiosity, what is the benefit of one over another here?

Now it can be compiled for more platforms(e.g. Windows).

[Alexey Proskuryakov]

This is WebKit2 code, and WebKit2 does not support Windows. That would be large undertaking, which should be discussed on webkit-dev before starting.

[Daewoong Jang]

(In reply to Alexey Proskuryakov from comment #6)
> This is WebKit2 code, and WebKit2 does not support Windows. That would be
> large undertaking, which should be discussed on webkit-dev before starting.

You are right if we are going to support WebKit2 on Windows, but this patch does not intend to do such a thing. I think it would not be a harm to use existing platform abstraction of WTF.

[Alex Christensen]

This is like https://bugs.webkit.org/show_bug.cgi?id=172667#c8
I want to keep accepting patches like this, but discuss on webkit-dev before deciding if we want to officially support large amounts of code.