Bug 173130 - Use WTF::getCurrentProcessID() instead of getpid().
Summary: Use WTF::getCurrentProcessID() instead of getpid().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daewoong Jang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-08 22:54 PDT by Daewoong Jang
Modified: 2017-06-13 12:50 PDT (History)
6 users (show)

See Also:

Attachments
patch (1.46 KB, patch)
2017-06-08 22:56 PDT, Daewoong Jang 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daewoong Jang 2017-06-08 22:54:35 PDT 
Use WTF::getCurrentProcessID() instead of getpid().
Comment 1 Daewoong Jang 2017-06-08 22:56:15 PDT 
Created attachment 312387 [details]
patch
Comment 2 WebKit Commit Bot 2017-06-09 03:39:59 PDT 
Comment on attachment 312387 [details]
patch

Clearing flags on attachment: 312387

Committed r217975: <http://trac.webkit.org/changeset/217975>
Comment 3 WebKit Commit Bot 2017-06-09 03:40:01 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Alexey Proskuryakov 2017-06-12 18:14:40 PDT 
Out of curiosity, what is the benefit of one over another here?
Comment 5 Daewoong Jang 2017-06-12 18:36:54 PDT 
(In reply to Alexey Proskuryakov from comment #4)
> Out of curiosity, what is the benefit of one over another here?

Now it can be compiled for more platforms(e.g. Windows).
Comment 6 Alexey Proskuryakov 2017-06-12 18:52:44 PDT 
This is WebKit2 code, and WebKit2 does not support Windows. That would be large undertaking, which should be discussed on webkit-dev before starting.
Comment 7 Daewoong Jang 2017-06-12 18:59:43 PDT 
(In reply to Alexey Proskuryakov from comment #6)
> This is WebKit2 code, and WebKit2 does not support Windows. That would be
> large undertaking, which should be discussed on webkit-dev before starting.

You are right if we are going to support WebKit2 on Windows, but this patch does not intend to do such a thing. I think it would not be a harm to use existing platform abstraction of WTF.
Comment 8 Alex Christensen 2017-06-13 12:50:43 PDT 
This is like https://bugs.webkit.org/show_bug.cgi?id=172667#c8
I want to keep accepting patches like this, but discuss on webkit-dev before deciding if we want to officially support large amounts of code.