Bug 172667 – Don't use designated initializers in WebBackForwardListProxy.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Konstantin Tokarev]

Designated initializers are not defined by C++ standard, and are not supported by MSVC.

[Konstantin Tokarev]

Created attachment 311382 [details]
Patch

[Sam Weinig]

WebKit2 does not support MSVC at this time, so I don't really see the point of this.

[Don Olmstead]

(In reply to Sam Weinig from comment #2)
> WebKit2 does not support MSVC at this time, so I don't really see the point
> of this.

We have some devs who have started preliminary work on WK2 for Windows. The Qt port has some of this functionality so we'd like to start landing it for WinCairo.

[Sam Weinig]

We explicitly removed support for Windows a little while ago, so I think a discussion on the mailing list is probably warranted to consider bringing it back.

[Konstantin Tokarev]

(In reply to Sam Weinig from comment #4)
> We explicitly removed support for Windows a little while ago, so I think a
> discussion on the mailing list is probably warranted to consider bringing it
> back.

I think there is a big difference between upstreaming Windows support in WK2, and just making port-independent code standards-compliant so people can use it in downstreams.

[Michael Catanzaro]

(In reply to Konstantin Tokarev from comment #5)
> I think there is a big difference between upstreaming Windows support in
> WK2, and just making port-independent code standards-compliant so people can
> use it in downstreams.

Yeah, Sam has a good point here regarding Windows support, but this patch seems good to me anyway as it is valuable to avoid nonstandard compiler features when they are unnecessary.

(FWIW: there are lots of projects that are missing Windows support for WebKitGTK+ and would love to have it -- e.g. Pidgen, GIMP, GnuCash -- but I doubt Igalia would be interested in maintaining it.)

[Konstantin Tokarev]

(In reply to Michael Catanzaro from comment #6)
> (In reply to Konstantin Tokarev from comment #5)
> > I think there is a big difference between upstreaming Windows support in
> > WK2, and just making port-independent code standards-compliant so people can
> > use it in downstreams.
> 
> Yeah, Sam has a good point here regarding Windows support, but this patch
> seems good to me anyway as it is valuable to avoid nonstandard compiler
> features when they are unnecessary.
> 
> (FWIW: there are lots of projects that are missing Windows support for
> WebKitGTK+ and would love to have it -- e.g. Pidgen, GIMP, GnuCash -- but I
> doubt Igalia would be interested in maintaining it.)

Note that Windows IPC works fine in my branch, so it maintaining WK2 for Igalia would be a matter of maintaining GTK-specific changes

[Alex Christensen]

Comment on attachment 311382 [details]
Patch

I think we should be ok with upstreaming this patch and others like it.  We should definitely discuss on webkit-dev before resurrecting or writing anew lots of Windows WK2 code.

[WebKit Commit Bot]

Comment on attachment 311382 [details]
Patch

Clearing flags on attachment: 311382

Committed r217564: <http://trac.webkit.org/changeset/217564>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/32479690>