Bug 173128 – [WebCrypto] Remove unsupported CryptoAlgorithmIdentifier

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Jiewen Tan]

Remove unsupported CryptoAlgorithmIdentifier.

[Radar WebKit Bug Importer]

<rdar://problem/32666826>

[Jiewen Tan]

Created attachment 312379 [details]
Patch

[Build Bot]

Attachment 312379 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:233:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:234:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:235:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:236:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:237:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:238:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:239:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:240:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:241:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:242:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:243:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 11 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brent Fulgham]

Comment on attachment 312379 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312379&action=review

> Source/WebCore/bindings/js/JSCryptoAlgorithmDictionary.cpp:-319
> -    case CryptoAlgorithmIdentifier::AES_CMAC:

When we remove these cases, do we have a general error handler that reports to the user that it is an unsupported algorithm?

If so, r=me.

[Jiewen Tan]

Comment on attachment 312379 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312379&action=review

Thanks Brent for r+ my patch.

>> Source/WebCore/bindings/js/JSCryptoAlgorithmDictionary.cpp:-319
>> -    case CryptoAlgorithmIdentifier::AES_CMAC:
> 
> When we remove these cases, do we have a general error handler that reports to the user that it is an unsupported algorithm?
> 
> If so, r=me.

Yes, we do.

[WebKit Commit Bot]

Comment on attachment 312379 [details]
Patch

Clearing flags on attachment: 312379

Committed r218030: <http://trac.webkit.org/changeset/218030>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Jon Lee]

this breaks Netflix.