Bug 172960 - ARES-6 incorrectly measures Worst 4 Iterations
Summary: ARES-6 incorrectly measures Worst 4 Iterations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on: 172962
Blocks:
  Show dependency tree / graph
 
Reported: 2017-06-05 23:18 PDT by Saam Barati
Modified: 2017-06-07 12:14 PDT (History)
13 users (show)

See Also:

Attachments
patch (2.77 KB, patch)
2017-06-05 23:22 PDT, Saam Barati 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2017-06-05 23:18:04 PDT 
It accidentally measures first 4.
Comment 1 Saam Barati 2017-06-05 23:22:57 PDT 
Created attachment 312059 [details]
patch
Comment 2 Mark Lam 2017-06-05 23:28:12 PDT 
Comment on attachment 312059 [details]
patch

r=me
Comment 3 Ryosuke Niwa 2017-06-05 23:31:33 PDT 
Comment on attachment 312059 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312059&action=review

> PerformanceTests/ARES-6/results.js:59
>  

We should version benchmarks. Otherwise, people can't tell which version of the benchmark they're running.
Comment 4 Saam Barati 2017-06-07 12:14:03 PDT 
landed in:
https://trac.webkit.org/changeset/217897/webkit