Bug 172962 - Add a version number to ARES-6
Summary: Add a version number to ARES-6
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks: 172960
  Show dependency tree / graph
 
Reported: 2017-06-05 23:45 PDT by Saam Barati
Modified: 2017-06-06 00:57 PDT (History)
14 users (show)

See Also:

Attachments
patch (2.00 KB, patch)
2017-06-05 23:59 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (2.28 KB, patch)
2017-06-06 00:17 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2017-06-05 23:45:19 PDT 
...
Comment 1 Saam Barati 2017-06-05 23:59:20 PDT 
Created attachment 312060 [details]
patch
Comment 2 Yusuke Suzuki 2017-06-06 00:01:58 PDT 
Comment on attachment 312060 [details]
patch

How about adding this number to benchmark driver in JS? It allows us to

1. Keep in sync with JS code change & ARES-6 version number.
2. Provide a way to print version number even in cli.js
Comment 3 Saam Barati 2017-06-06 00:17:46 PDT 
Created attachment 312061 [details]
patch
Comment 4 Yusuke Suzuki 2017-06-06 00:18:25 PDT 
Comment on attachment 312061 [details]
patch

r=me
Comment 5 WebKit Commit Bot 2017-06-06 00:57:48 PDT 
Comment on attachment 312061 [details]
patch

Clearing flags on attachment: 312061

Committed r217822: <http://trac.webkit.org/changeset/217822>
Comment 6 WebKit Commit Bot 2017-06-06 00:57:50 PDT 
All reviewed patches have been landed.  Closing bug.