Bug 172783 – [css-grid] Update W3C web platform tests for the CSS Grid Layout feature

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Javier Fernandez]

This is a meta-bug to track the process of importing the Web Platform Tests in the css-grid-1 folder of the W3C github. 

https://github.com/w3c/web-platform-tests/tree/master/css/css-grid-1

[Javier Fernandez]

It seems that the tests were initially added in bug #169196. There were several changes since that time, so I'll update the available tests and retrieve the new ones in this bug.

[Javier Fernandez]

Created attachment 311648 [details]
Patch

[Build Bot]

Comment on attachment 311648 [details]
Patch

Attachment 311648 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3850806

New failing tests:
imported/w3c/web-platform-tests/css/css-grid-1/grid-definition/grid-support-grid-template-areas-001.html
imported/w3c/web-platform-tests/css/css-grid-1/grid-definition/grid-inline-support-grid-template-areas-001.html

[Build Bot]

Created attachment 311656 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Javier Fernandez]

Created attachment 311662 [details]
Patch

[Manuel Rego Casasnovas]

Comment on attachment 311662 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311662&action=review

Thanks for doing this.

> LayoutTests/imported/w3c/ChangeLog:8
> +        Imported the last CSS Grid Layout web platform tests.

It's nice to refer to the git commit that we're importing from WPT for future reference.

For example like we do in: https://bugs.webkit.org/show_bug.cgi?id=172494

> LayoutTests/imported/w3c/resources/import-expectations.json:298
> +}

I guess this change was automatically done by the importer script.

[Javier Fernandez]

Comment on attachment 311662 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311662&action=review

>> LayoutTests/imported/w3c/ChangeLog:8
>> +        Imported the last CSS Grid Layout web platform tests.
> 
> It's nice to refer to the git commit that we're importing from WPT for future reference.
> 
> For example like we do in: https://bugs.webkit.org/show_bug.cgi?id=172494

Ok, I'll add that in to the ChangeLog before landing.

>> LayoutTests/imported/w3c/resources/import-expectations.json:298
>> +}
> 
> I guess this change was automatically done by the importer script.

Yes, it was added automatically.

[Javier Fernandez]

Created attachment 311693 [details]
Patch

[Javier Fernandez]

Created attachment 311695 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 311695 [details]
Patch

Clearing flags on attachment: 311695

Committed r217652: <http://trac.webkit.org/changeset/217652>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.