Bug 172494 - [css-grid] Import css/css-grid-1/alignment/ from WPT (8df7c9c215)
Summary: [css-grid] Import css/css-grid-1/alignment/ from WPT (8df7c9c215)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords:
Depends on:
Blocks: 60731 172493
  Show dependency treegraph
 
Reported: 2017-05-23 01:57 PDT by Manuel Rego Casasnovas
Modified: 2017-05-23 13:31 PDT (History)
6 users (show)

See Also:


Attachments
Patch (205.56 KB, patch)
2017-05-23 01:57 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff
Patch (205.60 KB, patch)
2017-05-23 03:00 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff
Patch for landing (205.66 KB, patch)
2017-05-23 12:15 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff
Rebased patch (205.58 KB, patch)
2017-05-23 12:58 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2017-05-23 01:57:15 PDT
[css-grid] Update CSS Grid Layout test suite
Comment 1 Manuel Rego Casasnovas 2017-05-23 01:57:43 PDT
Created attachment 310986 [details]
Patch
Comment 2 Build Bot 2017-05-23 02:01:57 PDT
Attachment 310986 [details] did not pass style-queue:


ERROR: LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
ERROR: LayoutTests/imported/w3c/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 2 in 113 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Manuel Rego Casasnovas 2017-05-23 03:00:18 PDT
Created attachment 310991 [details]
Patch
Comment 4 Javier Fernandez 2017-05-23 05:09:19 PDT
Comment on attachment 310991 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310991&action=review

> LayoutTests/imported/w3c/resources/import-expectations.json:-65
> -    "web-platform-tests/cssom/MediaList.xhtml": "skip", 

nit: Why this line change ?
Comment 5 Manuel Rego Casasnovas 2017-05-23 05:46:38 PDT
Comment on attachment 310991 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310991&action=review

>> LayoutTests/imported/w3c/resources/import-expectations.json:-65
>> -    "web-platform-tests/cssom/MediaList.xhtml": "skip", 
> 
> nit: Why this line change ?

That file is updated by the import script, not manually so I prefer to let it do whatever change it wants on it. :-)
Comment 6 youenn fablet 2017-05-23 08:27:55 PDT
Comment on attachment 310991 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310991&action=review

> LayoutTests/imported/w3c/ChangeLog:11
> +        to reference files there and the importer wasn't able to get them.

It is not clear from the title how this gets updated.
Isn't it that you are adding web-platform-tests/css/css-grid-1/alignment/ and need to update css/reference?
Ideally, you would use the wpt revision in resources/TestRepositories, by doing something like import-w3c-tests web-platform-tests/css/css-grid-1/alignment.

>>> LayoutTests/imported/w3c/resources/import-expectations.json:-65
>>> -    "web-platform-tests/cssom/MediaList.xhtml": "skip", 
>> 
>> nit: Why this line change ?
> 
> That file is updated by the import script, not manually so I prefer to let it do whatever change it wants on it. :-)

Yes, this line was added manually but the importer is reordering these.
Comment 7 Manuel Rego Casasnovas 2017-05-23 12:07:38 PDT
Comment on attachment 310991 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310991&action=review

Thanks for the review.

>> LayoutTests/imported/w3c/ChangeLog:11
>> +        to reference files there and the importer wasn't able to get them.
> 
> It is not clear from the title how this gets updated.
> Isn't it that you are adding web-platform-tests/css/css-grid-1/alignment/ and need to update css/reference?
> Ideally, you would use the wpt revision in resources/TestRepositories, by doing something like import-w3c-tests web-platform-tests/css/css-grid-1/alignment.

So basically I was downloading the new changes on Grid Layout. In this case it was only that folder that's true.
I was using:
  Tools/Scripts/import-w3c-tests web-platform-tests/css/css-grid-1 -t

And at the same time I needed to somehow start importing "css/reference" so I was using:
    Tools/Scripts/import-w3c-tests web-platform-tests/css/reference -t

I'd update the ChangeLog to make it more explicit.
Comment 8 Manuel Rego Casasnovas 2017-05-23 12:15:02 PDT
Created attachment 311038 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2017-05-23 12:47:57 PDT
Comment on attachment 311038 [details]
Patch for landing

Rejecting attachment 311038 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 311038, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
..1a5e283  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 217288 = d8ecdf893767aa4ac0d2a20b290f74ff2f76350e
r217289 = 1a5e28314879dcd6e241ffe89001a24f9d7aa12f
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Total errors found: 0 in 1 files

Full output: http://webkit-queues.webkit.org/results/3802009
Comment 10 Manuel Rego Casasnovas 2017-05-23 12:58:20 PDT
Created attachment 311041 [details]
Rebased patch
Comment 11 youenn fablet 2017-05-23 13:10:22 PDT
I saw some issues with out-of-sync WPT tests.
When using the current revision of WPT, it is ok not to mention it.
Otherwise, it is good to mention it.
Comment 12 WebKit Commit Bot 2017-05-23 13:31:57 PDT
Comment on attachment 311041 [details]
Rebased patch

Clearing flags on attachment: 311041

Committed r217294: <http://trac.webkit.org/changeset/217294>
Comment 13 WebKit Commit Bot 2017-05-23 13:31:59 PDT
All reviewed patches have been landed.  Closing bug.