Bug 172660 – Prevent async methods named 'function' in Object literal

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[GSkachkov]

```
({
  async function() {}
})
```
Should be syntax error:
https://github.com/tc39/ecma262/pull/884
https://github.com/tc39/test262/pull/967/files#diff-0fc4f159cc11cd6471944c682729ff0dR17

[GSkachkov]

Created attachment 311433 [details]
Patch

Patch

[Build Bot]

Comment on attachment 311433 [details]
Patch

Attachment 311433 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3831230

New failing tests:
http/tests/cache/cancel-during-revalidation-succeeded.html

[Build Bot]

Created attachment 311434 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Saam Barati]

Comment on attachment 311433 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311433&action=review

> Source/JavaScriptCore/parser/Parser.cpp:3724
> +            semanticFailIfTrue(isAsyncMethod && !isGenerator && *ident == m_vm->propertyNames->functionKeyword, "Cannot declare an async method named 'function'");

This does not apply to generators? Also, why do this here and not in parsePropertyMethod?

[GSkachkov]

Created attachment 311469 [details]
Patch

Patch with fixed comments

[Build Bot]

Comment on attachment 311469 [details]
Patch

Attachment 311469 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3837098

New failing tests:
webrtc/peer-connection-audio-mute.html

[Build Bot]

Created attachment 311471 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[GSkachkov]

Comment on attachment 311433 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311433&action=review

>> Source/JavaScriptCore/parser/Parser.cpp:3724
>> +            semanticFailIfTrue(isAsyncMethod && !isGenerator && *ident == m_vm->propertyNames->functionKeyword, "Cannot declare an async method named 'function'");
> 
> This does not apply to generators? Also, why do this here and not in parsePropertyMethod?

According to PR, it make changes only in Async function, but as for now we do not have asyncGenerator, so we can remove !isGenerator.
I've checked that parsePropertyMethod used 3 times, so I decided to add condition in place that used to parse Object literal, to prevent checking when it definitely not our case.In new patch I added to parsePropertyMethod

[Saam Barati]

Comment on attachment 311469 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 311469 [details]
Patch

Clearing flags on attachment: 311469

Committed r217578: <http://trac.webkit.org/changeset/217578>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/32479687>

[Mark Lam]

We probably want to roll this out.  See https://bugs.webkit.org/show_bug.cgi?id=172598#c14

[GSkachkov]

(In reply to Mark Lam from comment #13)
> We probably want to roll this out.  See
> https://bugs.webkit.org/show_bug.cgi?id=172598#c14

Yeah, I see. Will create patch to rollback this changes.