See https://github.com/tc39/ecma262/pull/884?
Created attachment 311271 [details] Patch Patch
Comment on attachment 311271 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311271&action=review > Source/JavaScriptCore/ChangeLog:3 > + Prevent async methods named âfunctionâ Please fix non-ascii characters in the description. Please also add a url to the spec or maybe https://github.com/tc39/ecma262/pull/884 that specifies this behavior.
Comment on attachment 311271 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311271&action=review > JSTests/ChangeLog:3 > + Prevent async methods named âfunctionâ Ditto for non-ascii characters.
Created attachment 311274 [details] Patch Patch with fixes
Comment on attachment 311271 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311271&action=review >> Source/JavaScriptCore/ChangeLog:3 >> + Prevent async methods named âfunctionâ > > Please fix non-ascii characters in the description. > > Please also add a url to the spec or maybe https://github.com/tc39/ecma262/pull/884 that specifies this behavior. Fixed >> JSTests/ChangeLog:3 >> + Prevent async methods named âfunctionâ > > Ditto for non-ascii characters. Oh, it seems that taken from task name. Fixed
Comment on attachment 311274 [details] Patch r=me
Comment on attachment 311274 [details] Patch Clearing flags on attachment: 311274 Committed r217478: <http://trac.webkit.org/changeset/217478>
All reviewed patches have been landed. Closing bug.
Comment on attachment 311274 [details] Patch Does this effect Object liberals? If so, please add a test
Yeah?(In reply to Saam Barati from comment #9) > Comment on attachment 311274 [details] > Patch > > Does this effect Object liberals? If so, please add a test Yeah you are right, I was focused on class methods, but spec cover object literals as well https://github.com/tc39/test262/pull/967/files#diff-0fc4f159cc11cd6471944c682729ff0dR17 I've prepared fix, expect to upload it to separate issue tomorrow. Thanks for comment.
(In reply to Saam Barati from comment #9) > Comment on attachment 311274 [details] > Patch > > Does this effect Object liberals? If so, please add a test There is a patch that cover object literals https://bugs.webkit.org/show_bug.cgi?id=172660
<rdar://problem/32479725>
We reviewed this PR at TC39 and decided *not* to do this spec change, and to leave things as is, permitting async methods named function. Sorry for the confusion.
(In reply to Daniel Ehrenberg from comment #13) > We reviewed this PR at TC39 and decided *not* to do this spec change, and to > leave things as is, permitting async methods named function. Sorry for the > confusion. Thanks for catching this! Reference: https://github.com/tc39/ecma262/pull/884
(In reply to Daniel Ehrenberg from comment #13) > We reviewed this PR at TC39 and decided *not* to do this spec change, and to > leave things as is, permitting async methods named function. Sorry for the > confusion. Ups. Will do rollback. Thanks for update.