Bug 172629 - Fix MediaDeviceInfo's extended attributes so they make sense
Summary: Fix MediaDeviceInfo's extended attributes so they make sense
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-25 21:16 PDT by Sam Weinig
Modified: 2017-05-30 20:21 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.50 KB, patch)
2017-05-25 21:19 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2017-05-25 21:16:04 PDT
Fix MediaDeviceInfo's extended attributes so they make sense
Comment 1 Sam Weinig 2017-05-25 21:19:15 PDT
Created attachment 311333 [details]
Patch
Comment 2 Daniel Bates 2017-05-25 21:48:23 PDT
Comment on attachment 311333 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311333&action=review

> Source/WebCore/Modules/mediastream/MediaDeviceInfo.idl:-37
> -    // FIXME 169871: missing serializer

Can we close bug #169871?
Comment 3 Sam Weinig 2017-05-25 22:11:28 PDT
(In reply to Daniel Bates from comment #2)
> Comment on attachment 311333 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=311333&action=review
> 
> > Source/WebCore/Modules/mediastream/MediaDeviceInfo.idl:-37
> > -    // FIXME 169871: missing serializer
> 
> Can we close bug #169871?

No. It looks to be an umbrella bug. I'll let Jon decide if its done.
Comment 4 WebKit Commit Bot 2017-05-25 22:39:16 PDT
Comment on attachment 311333 [details]
Patch

Clearing flags on attachment: 311333

Committed r217476: <http://trac.webkit.org/changeset/217476>
Comment 5 WebKit Commit Bot 2017-05-25 22:39:17 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-05-30 20:21:03 PDT
<rdar://problem/32479701>