Bug 169871 - Update MediaStream and friend IDLs
Summary: Update MediaStream and friend IDLs
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on: 167518 169872 169873 169877 169879
Blocks:
  Show dependency treegraph
 
Reported: 2017-03-20 00:20 PDT by Jon Lee
Modified: 2020-09-14 23:57 PDT (History)
5 users (show)

See Also:


Attachments
Patch (10.42 KB, patch)
2017-08-28 12:44 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (10.74 KB, patch)
2017-08-28 12:45 PDT, youenn fablet
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.39 MB, application/zip)
2017-08-28 13:29 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2017-03-20 00:20:33 PDT
Update media stream IDL
Comment 1 youenn fablet 2017-08-28 12:44:10 PDT
Created attachment 319193 [details]
Patch
Comment 2 youenn fablet 2017-08-28 12:45:20 PDT
Created attachment 319195 [details]
Patch
Comment 3 Jon Lee 2017-08-28 13:29:41 PDT
Comment on attachment 319195 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319195&action=review

> Source/WebCore/ChangeLog:11
> +        active attribute is still kept and is updated synchronously on every track change.

Please file a new bug for this patch. This bug covers multiple issues (search for "FIXME 169871" in WebCore).

> Source/WebCore/Modules/mediastream/MediaStream.idl:-53
> -

Update the copyright on this file, please.
Comment 4 Build Bot 2017-08-28 13:29:55 PDT
Comment on attachment 319195 [details]
Patch

Attachment 319195 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4398813

New failing tests:
fast/mediacapturefromelement/CanvasCaptureMediaStream-creation.html
fast/mediacapturefromelement/CanvasCaptureMediaStream-clone-track.html
Comment 5 Build Bot 2017-08-28 13:29:56 PDT
Created attachment 319199 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Sam Weinig 2020-09-13 09:50:59 PDT
Jon/Youenn, anything left to do here?
Comment 7 youenn fablet 2020-09-13 23:20:53 PDT
(In reply to Sam Weinig from comment #6)
> Jon/Youenn, anything left to do here?

Some track constraints are not yet supported.
InputDeviceInfo is not supported.
Comment 8 Sam Weinig 2020-09-14 10:46:50 PDT
(In reply to youenn fablet from comment #7)
> (In reply to Sam Weinig from comment #6)
> > Jon/Youenn, anything left to do here?
> 
> Some track constraints are not yet supported.
> InputDeviceInfo is not supported.

Is this bug still useful for tracking that? To me, it's unclear what this bug is trying to resolve.
Comment 9 youenn fablet 2020-09-14 23:57:13 PDT
(In reply to Sam Weinig from comment #8)
> (In reply to youenn fablet from comment #7)
> > (In reply to Sam Weinig from comment #6)
> > > Jon/Youenn, anything left to do here?
> > 
> > Some track constraints are not yet supported.
> > InputDeviceInfo is not supported.
> 
> Is this bug still useful for tracking that? To me, it's unclear what this
> bug is trying to resolve.

Some IDLs files refer to that bug ID.