Bug 169877 - Wrap legacy MediaStream API in runtime flag
Summary: Wrap legacy MediaStream API in runtime flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks: 169871
  Show dependency tree / graph
 
Reported: 2017-03-20 10:38 PDT by Jon Lee
Modified: 2017-04-10 14:02 PDT (History)
5 users (show)

See Also:

Attachments
Patch (9.85 KB, patch)
2017-04-10 10:53 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (9.90 KB, patch)
2017-04-10 12:19 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (9.94 KB, patch)
2017-04-10 13:19 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2017-03-20 10:38:04 PDT 
For consideration:
- NavigatorUserMedia.idl
- MediaStreamEvent.idl
Comment 1 youenn fablet 2017-04-10 10:53:05 PDT 
Created attachment 306711 [details]
Patch
Comment 2 youenn fablet 2017-04-10 12:19:10 PDT 
Created attachment 306728 [details]
Patch
Comment 3 WebKit Commit Bot 2017-04-10 13:15:58 PDT 
Comment on attachment 306728 [details]
Patch

Rejecting attachment 306728 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 306728, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
a/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 54, in run
    if changelog_entry.has_valid_reviewer():
AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'

Full output: http://webkit-queues.webkit.org/results/3512974
Comment 4 youenn fablet 2017-04-10 13:19:43 PDT 
Created attachment 306732 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2017-04-10 14:02:19 PDT 
Comment on attachment 306732 [details]
Patch for landing

Clearing flags on attachment: 306732

Committed r215200: <http://trac.webkit.org/changeset/215200>
Comment 6 WebKit Commit Bot 2017-04-10 14:02:21 PDT 
All reviewed patches have been landed.  Closing bug.