Bug 172615 - ASSERT(m_websiteDataStore->websiteDataStore().sessionID() == m_sessionID) in PageConfiguration::sessionID()
Summary: ASSERT(m_websiteDataStore->websiteDataStore().sessionID() == m_sessionID) in ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 171408
  Show dependency tree / graph
 
Reported: 2017-05-25 15:24 PDT by Chris Dumez
Modified: 2017-05-25 15:33 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.28 KB, patch)
2017-05-25 15:27 PDT, Chris Dumez 		beidson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-05-25 15:24:46 PDT 
ASSERT(m_websiteDataStore->websiteDataStore().sessionID() == m_sessionID) is sometimes hit in PageConfiguration::sessionID().
Comment 1 Chris Dumez 2017-05-25 15:25:00 PDT 
<rdar://problem/32277488>
Comment 2 Chris Dumez 2017-05-25 15:27:37 PDT 
Created attachment 311302 [details]
Patch
Comment 3 Chris Dumez 2017-05-25 15:33:02 PDT 
Comment on attachment 311302 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311302&action=review

> Source/WebKit2/UIProcess/API/APIPageConfiguration.cpp:158
> +    RELEASE_ASSERT(!m_websiteDataStore || m_websiteDataStore->websiteDataStore().sessionID() == m_sessionID || m_sessionID == SessionID::legacyPrivateSessionID());

Didn't mean to make this a RELEASE_ASSERT. Will fix before landing.
Comment 4 Chris Dumez 2017-05-25 15:33:32 PDT 
Committed r217455: <http://trac.webkit.org/changeset/217455>