Bug 171408 – Teach WebProcessPool to track a map of SessionIDs to WebPageProxys to manage their lifetime

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brady Eidson]

Teach WebProcessPool to track a map of SessionIDs to WebPageProxys to manage their lifetime

[Brady Eidson]

Created attachment 308503 [details]
Patch

[Alex Christensen]

Comment on attachment 308503 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308503&action=review

> Source/WebKit2/UIProcess/WebProcessPool.cpp:954
> +        // FIXME: Remove this ASSERT and change these messages once multiple persistent sessions exist.
> +        ASSERT(sessionID.isEphemeral());
> +        networkProcess()->send(Messages::NetworkProcess::DestroyPrivateBrowsingSession(sessionID), 0);
> +        page.process().send(Messages::WebProcess::DestroyPrivateBrowsingSession(sessionID), 0);

I guess we'll also rename DestroyPrivateBrowsingSession to DestroySession, right?

> Source/WebKit2/UIProcess/WebProcessProxy.cpp:293
> +    auto removedPage = m_pageMap.take(pageID);

auto*

[Brady Eidson]

(In reply to Alex Christensen from comment #2)
> Comment on attachment 308503 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=308503&action=review
> 
> > Source/WebKit2/UIProcess/WebProcessPool.cpp:954
> > +        // FIXME: Remove this ASSERT and change these messages once multiple persistent sessions exist.
> > +        ASSERT(sessionID.isEphemeral());
> > +        networkProcess()->send(Messages::NetworkProcess::DestroyPrivateBrowsingSession(sessionID), 0);
> > +        page.process().send(Messages::WebProcess::DestroyPrivateBrowsingSession(sessionID), 0);
> 
> I guess we'll also rename DestroyPrivateBrowsingSession to DestroySession,
> right?

Yup.

> 
> > Source/WebKit2/UIProcess/WebProcessProxy.cpp:293
> > +    auto removedPage = m_pageMap.take(pageID);
> 
> auto*

Sure.

[Brady Eidson]

Created attachment 308505 [details]
Patch

[Brady Eidson]

Will cq+ after EWS starts to look green

[Brady Eidson]

EWS is unhappy with 215916 I think

[WebKit Commit Bot]

Comment on attachment 308505 [details]
Patch

Clearing flags on attachment: 308505

Committed r215923: <http://trac.webkit.org/changeset/215923>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Geoffrey Garen]

Comment on attachment 308505 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308505&action=review

> Source/WebKit2/UIProcess/API/APIPageConfiguration.cpp:160
> +#if !ASSERT_DISABLED
> +    if (m_websiteDataStore)
> +        ASSERT(m_websiteDataStore->websiteDataStore().sessionID() == m_sessionID);
> +#endif

You can ASSERT(!m_websiteDataStore || ...) to avoid the #ifdef.