The aria-details attribute was added in ARIA 1.1. According to the Core AAM [1]: "If the referenced object is in the accessibility tree, expose a pointer to the accessible object using RELATION_DETAILS, and expose reverse relations as described in Relations." The reverse relation type for RELATION_DETAILS is RELATION_DETAILS_FOR. [1] https://rawgit.com/w3c/aria/master/core-aam/core-aam.html#ariaDetails
<rdar://problem/32401029>
Note that the relation types needed to implement this support will require we update the minimum versions of atk, at-spi2-core, and at-spi2-atk in jhbuild to at least 2.15.2. That also needs to be done in order to fix bug 172355, for which there is a proposed patch. Therefore making this bug depend on 172355.
(Combining bugs since the implementation of aria-details and aria-errormessage should be simple, small, and quite similar and share the same dependencies.) The aria-errormessage attribute was added in ARIA 1.1. According to the Core AAM [1]: "If the referenced object is in the accessibility tree, expose a pointer to the accessible object using RELATION_ERROR_MESSAGE, and expose reverse relations as described in Relations." The reverse relation type for RELATION_ERROR_MESSAGE is RELATION_ERROR_FOR. Note that the relation types needed to implement this support will require we update the minimum versions of atk, at-spi2-core, and at-spi2-atk in jhbuild to at least 2.15.2. That also needs to be done in order to fix bug 172355, for which there is a proposed patch. Therefore making this bug depend on 172355. [1] https://rawgit.com/w3c/aria/master/core-aam/core-aam.html#ariaErrorMessage
*** Bug 172589 has been marked as a duplicate of this bug. ***
Fixing this depends on fixing bug 155494 because the implementation requires reverse relations.
Created attachment 313825 [details] Patch
Attachment 313825 [details] did not pass style-queue: ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:206: 'ariaDetailsElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:207: 'ariaDetailsReferencingElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:208: 'ariaErrorMessageElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:209: 'ariaErrorMessageReferencingElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] Total errors found: 4 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to Build Bot from comment #7) > If any of these errors are false positives, please file a bug against > check-webkit-style. They are either false positives or we need to rename a bunch of methods in WKTR and update many of the accessibility Layout Tests which call those methods. If it's the latter case, it goes beyond the scope of this bug.
Created attachment 313837 [details] Patch
Attachment 313837 [details] did not pass style-queue: ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:206: 'ariaDetailsElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:207: 'ariaDetailsReferencingElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:208: 'ariaErrorMessageElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:209: 'ariaErrorMessageReferencingElementAtIndex' is incorrectly named. It should be named 'protector' or 'protectedUnsigned'. [readability/naming/protected] [4] Total errors found: 4 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 313837 [details] Patch Clearing flags on attachment: 313837 Committed r218809: <http://trac.webkit.org/changeset/218809>
All reviewed patches have been landed. Closing bug.
*** Bug 165190 has been marked as a duplicate of this bug. ***