Bug 172355 - [ATK] Expose doc-footnote ARIA role with ATK_ROLE_FOOTNOTE
Summary: [ATK] Expose doc-footnote ARIA role with ATK_ROLE_FOOTNOTE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All Linux
: P2 Normal
Assignee: Joanmarie Diggs
URL:
Keywords: InRadar
Depends on:
Blocks: 172588 172589
  Show dependency treegraph
 
Reported: 2017-05-19 03:45 PDT by Joanmarie Diggs
Modified: 2017-05-25 10:16 PDT (History)
10 users (show)

See Also:


Attachments
Patch (10.27 KB, patch)
2017-05-25 05:33 PDT, Joanmarie Diggs
no flags Details | Formatted Diff | Diff
Patch (11.08 KB, patch)
2017-05-25 08:57 PDT, Joanmarie Diggs
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joanmarie Diggs 2017-05-19 03:45:22 PDT
The DPub ARIA "doc-footnote" role should be exposed with ATK_ROLE_FOOTNOTE. This was not done during the initial implementation because there was not (yet) a ROLE_FOOTNOTE in ATK or AT-SPI2. That new role landed in ATK and AT-SPI2 today and should be included in the next unstable releases of those modules. Once the role is available in a release, we can expose doc-footnote with the new platform role.
Comment 1 Radar WebKit Bug Importer 2017-05-19 03:45:52 PDT
<rdar://problem/32291847>
Comment 2 Joanmarie Diggs 2017-05-25 05:33:02 PDT
Created attachment 311214 [details]
Patch
Comment 3 Joanmarie Diggs 2017-05-25 08:57:12 PDT
Created attachment 311224 [details]
Patch
Comment 4 WebKit Commit Bot 2017-05-25 09:43:27 PDT
Comment on attachment 311224 [details]
Patch

Clearing flags on attachment: 311224

Committed r217426: <http://trac.webkit.org/changeset/217426>
Comment 5 WebKit Commit Bot 2017-05-25 09:43:28 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Claudio Saavedra 2017-05-25 09:55:44 PDT
Committed r217428: <http://trac.webkit.org/changeset/217428>
Comment 7 Claudio Saavedra 2017-05-25 09:57:05 PDT
(In reply to Claudio Saavedra from comment #6)
> Committed r217428: <http://trac.webkit.org/changeset/217428>

I have no idea what happened here, I just landed a new baseline with 'webkit-patch land' and it edited this bug. :/
Comment 8 Joanmarie Diggs 2017-05-25 10:16:21 PDT
(In reply to Claudio Saavedra from comment #7)
> (In reply to Claudio Saavedra from comment #6)
> > Committed r217428: <http://trac.webkit.org/changeset/217428>
> 
> I have no idea what happened here, I just landed a new baseline with
> 'webkit-patch land' and it edited this bug. :/

Yay technology.

It doesn't appear to have changed my code, so whatever.