Bug 172348 - Speedometer 2.0: Vanilla JS test doesn't mark all todo items as completed
Summary: Speedometer 2.0: Vanilla JS test doesn't mark all todo items as completed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 172339
  Show dependency tree / graph
 
Reported: 2017-05-19 00:39 PDT by Ryosuke Niwa
Modified: 2017-05-19 02:19 PDT (History)
8 users (show)

See Also:

Attachments
Fixes the bug (1.84 KB, patch)
2017-05-19 00:42 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-05-19 00:39:43 PDT 
The problem is that the memory storage class uses ms precision wall clock as a storage ID.
Because we're adding 50 items at all once, some items would inevitably end up having the same ID.
This results in multiple todo items sharing a single ID and cause havoc.

Use a monotonically increasing number as an ID instead.
Comment 1 Ryosuke Niwa 2017-05-19 00:42:48 PDT 
Created attachment 310629 [details]
Fixes the bug
Comment 2 Antti Koivisto 2017-05-19 01:51:12 PDT 
Comment on attachment 310629 [details]
Fixes the bug

r=me
Comment 3 WebKit Commit Bot 2017-05-19 02:19:05 PDT 
Comment on attachment 310629 [details]
Fixes the bug

Clearing flags on attachment: 310629

Committed r217107: <http://trac.webkit.org/changeset/217107>
Comment 4 WebKit Commit Bot 2017-05-19 02:19:07 PDT 
All reviewed patches have been landed.  Closing bug.