Bug 172347 - Speedometer 2.0: Flight.js test is sometime broken
Summary: Speedometer 2.0: Flight.js test is sometime broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 172339
  Show dependency tree / graph
 
Reported: 2017-05-19 00:24 PDT by Ryosuke Niwa
Modified: 2017-05-19 03:05 PDT (History)
8 users (show)

See Also:

Attachments
Fixes the test (2.64 KB, patch)
2017-05-19 00:29 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Wait for dependencies to load (4.23 KB, patch)
2017-05-19 02:49 PDT, Ryosuke Niwa 		koivisto: review+
rniwa: commit-queue+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-05-19 00:24:42 PDT 
Flight.js test is flaky because it doesn't always wait for the app to be ready.
We need to add the same hack as v1 to wait for all dependencies to be loaded via require.js
Comment 1 Ryosuke Niwa 2017-05-19 00:29:58 PDT 
Created attachment 310628 [details]
Fixes the test
Comment 2 Antti Koivisto 2017-05-19 01:56:56 PDT 
Comment on attachment 310628 [details]
Fixes the test

r=me
Comment 3 Ryosuke Niwa 2017-05-19 02:49:55 PDT 
Created attachment 310641 [details]
Wait for dependencies to load
Comment 4 Ryosuke Niwa 2017-05-19 03:05:14 PDT 
Committed r217118: <http://trac.webkit.org/changeset/217118>