WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
172347
Speedometer 2.0: Flight.js test is sometime broken
https://bugs.webkit.org/show_bug.cgi?id=172347
Summary
Speedometer 2.0: Flight.js test is sometime broken
Ryosuke Niwa
Reported
2017-05-19 00:24:42 PDT
Flight.js test is flaky because it doesn't always wait for the app to be ready. We need to add the same hack as v1 to wait for all dependencies to be loaded via require.js
Attachments
Fixes the test
(2.64 KB, patch)
2017-05-19 00:29 PDT
,
Ryosuke Niwa
no flags
Details
Formatted Diff
Diff
Wait for dependencies to load
(4.23 KB, patch)
2017-05-19 02:49 PDT
,
Ryosuke Niwa
koivisto
: review+
rniwa
: commit-queue+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2017-05-19 00:29:58 PDT
Created
attachment 310628
[details]
Fixes the test
Antti Koivisto
Comment 2
2017-05-19 01:56:56 PDT
Comment on
attachment 310628
[details]
Fixes the test r=me
Ryosuke Niwa
Comment 3
2017-05-19 02:49:55 PDT
Created
attachment 310641
[details]
Wait for dependencies to load
Ryosuke Niwa
Comment 4
2017-05-19 03:05:14 PDT
Committed
r217118
: <
http://trac.webkit.org/changeset/217118
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug