Bug 172294 - [JSC] Remove PLATFORM(WIN) references
Summary: [JSC] Remove PLATFORM(WIN) references
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
Depends on:
Blocks: 172144
  Show dependency treegraph
Reported: 2017-05-18 11:17 PDT by Don Olmstead
Modified: 2017-05-19 02:39 PDT (History)
9 users (show)

See Also:

Patch (4.15 KB, patch)
2017-05-18 11:24 PDT, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2017-05-18 11:17:28 PDT
PLATFORM(WIN) should not be used when OS(WINDOWS) can be used.
Comment 1 Don Olmstead 2017-05-18 11:18:11 PDT
Blocks compilation of JSCOnly on Windows.
Comment 2 Don Olmstead 2017-05-18 11:24:43 PDT
Created attachment 310521 [details]

Using OS(WINDOWS) instead of PLATFORM(WIN).

Updated Offline ASM to check for MSVC instead of PLATFORM(WIN) for MASM.
Comment 3 Konstantin Tokarev 2017-05-18 11:40:10 PDT
Comment 4 Yusuke Suzuki 2017-05-19 02:11:46 PDT
Comment on attachment 310521 [details]

OK, r=me
Comment 5 WebKit Commit Bot 2017-05-19 02:39:31 PDT
Comment on attachment 310521 [details]

Clearing flags on attachment: 310521

Committed r217109: <http://trac.webkit.org/changeset/217109>
Comment 6 WebKit Commit Bot 2017-05-19 02:39:33 PDT
All reviewed patches have been landed.  Closing bug.