Bug 172253 - [Cocoa] errors are not propagated to PassKit when calling ApplePaySession.completePayment()
Summary: [Cocoa] errors are not propagated to PassKit when calling ApplePaySession.com...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-17 16:39 PDT by Andy Estes
Modified: 2017-05-17 17:58 PDT (History)
8 users (show)

See Also:


Attachments
Patch (2.42 KB, patch)
2017-05-17 16:46 PDT, Andy Estes
no flags Details | Formatted Diff | Diff
Patch (2.42 KB, patch)
2017-05-17 17:17 PDT, Andy Estes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2017-05-17 16:39:04 PDT
[Cocoa] errors are not propogated to PassKit when calling ApplePaySession.completePayment()
Comment 1 Andy Estes 2017-05-17 16:41:25 PDT
rdar://problem/32258020
Comment 2 Andy Estes 2017-05-17 16:46:11 PDT
Created attachment 310461 [details]
Patch
Comment 3 Andy Estes 2017-05-17 16:48:56 PDT
Comment on attachment 310461 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310461&action=review

> Source/WebCore/ChangeLog:3
> +        [Cocoa] errors are not propogated to PassKit when calling ApplePaySession.completePayment()

Will fix my shameful spelling error before landing.
Comment 4 mitz 2017-05-17 17:08:20 PDT
Can we make it a runtime error to call releaseReturnValue a second time, at least in Debug builds?
Comment 5 Andy Estes 2017-05-17 17:15:40 PDT
(In reply to mitz from comment #4)
> Can we make it a runtime error to call releaseReturnValue a second time, at
> least in Debug builds?

I filed https://bugs.webkit.org/show_bug.cgi?id=172256

Thanks for the review!
Comment 6 Andy Estes 2017-05-17 17:17:12 PDT
Created attachment 310466 [details]
Patch
Comment 7 WebKit Commit Bot 2017-05-17 17:58:57 PDT
Comment on attachment 310466 [details]
Patch

Clearing flags on attachment: 310466

Committed r217022: <http://trac.webkit.org/changeset/217022>
Comment 8 WebKit Commit Bot 2017-05-17 17:58:59 PDT
All reviewed patches have been landed.  Closing bug.