Bug 169427 - Add delegate support to WebCore
Summary: Add delegate support to WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-09 12:31 PST by Anders Carlsson
Modified: 2017-05-17 16:41 PDT (History)
9 users (show)

See Also:

Attachments
Patch (120.76 KB, patch)
2017-03-09 12:44 PST, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (120.80 KB, patch)
2017-03-09 13:09 PST, Anders Carlsson 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2017-03-09 12:31:12 PST 
Add delegate support to WebCore
Comment 1 Anders Carlsson 2017-03-09 12:44:15 PST 
Created attachment 303956 [details]
Patch
Comment 2 WebKit Commit Bot 2017-03-09 12:46:05 PST 
Attachment 303956 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/applepay/ApplePayError.cpp:38:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2017-03-09 13:09:33 PST 
Created attachment 303969 [details]
Patch
Comment 4 Geoffrey Garen 2017-03-09 13:12:38 PST 
Comment on attachment 303969 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2017-03-09 13:13:42 PST 
Attachment 303969 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/applepay/ApplePayError.cpp:40:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Anders Carlsson 2017-03-09 14:34:58 PST 
Committed r213673: <http://trac.webkit.org/changeset/213673>
Comment 7 Alexey Proskuryakov 2017-03-13 10:08:34 PDT 
Comment on attachment 303969 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303969&action=review

> Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:38
> +TARGET_MAC_OS_X_VERSION_LESS_THAN_1013000 = $(TARGET_MAC_OS_X_VERSION_LESS_THAN_1013000_$(TARGET_MAC_OS_X_VERSION_MAJOR));

Is this too many zeroes?
Comment 8 Anders Carlsson 2017-03-13 10:13:45 PDT 
(In reply to comment #7)
> Comment on attachment 303969 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=303969&action=review
> 
> > Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:38
> > +TARGET_MAC_OS_X_VERSION_LESS_THAN_1013000 = $(TARGET_MAC_OS_X_VERSION_LESS_THAN_1013000_$(TARGET_MAC_OS_X_VERSION_MAJOR));
> 
> Is this too many zeroes?

Looks like it! It was copied from TARGET_MAC_OS_X_VERSION_LESS_THAN_1012000 :)