Bug 171864 - [Win] Specify source file type when preprocessing IDL files
Summary: [Win] Specify source file type when preprocessing IDL files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on:
Blocks: 171618
  Show dependency tree / graph
 
Reported: 2017-05-09 10:37 PDT by Don Olmstead
Modified: 2017-05-10 07:31 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.21 KB, patch)
2017-05-09 16:27 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2017-05-09 10:37:53 PDT 
The source file type, https://msdn.microsoft.com/en-us/library/032xwy55.aspx, should be specified to the preprocessor when running IDL generation.
Comment 1 Don Olmstead 2017-05-09 16:27:25 PDT 
Created attachment 309559 [details]
Patch

Adds /FP to the list of CODE_GENERATOR_PREPROCESSOR_ARGUMENTS. This is equivalent to the -x cpp used in GCC/Clang.
Comment 2 Alex Christensen 2017-05-09 16:55:29 PDT 
I have a bot building with VS2017 now and it's fine without this.  What does this improve or fix?
Comment 3 Don Olmstead 2017-05-09 17:01:41 PDT 
(In reply to Alex Christensen from comment #2)
> I have a bot building with VS2017 now and it's fine without this.  What does
> this improve or fix?

I'm trying to get things building with clang-cl.

With cl the flag isn't explicitly needed for it to function. With clang-cl if the flag isn't there then it returns nothing to STDOUT and the build fails.
Comment 4 WebKit Commit Bot 2017-05-10 07:31:33 PDT 
Comment on attachment 309559 [details]
Patch

Clearing flags on attachment: 309559

Committed r216583: <http://trac.webkit.org/changeset/216583>
Comment 5 WebKit Commit Bot 2017-05-10 07:31:34 PDT 
All reviewed patches have been landed.  Closing bug.