Bug 171858 - Print more properties in the output of scrolling trees
Summary: Print more properties in the output of scrolling trees
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords: InRadar
Depends on: 171802 171848
Blocks:
  Show dependency tree / graph
 
Reported: 2017-05-09 07:52 PDT by Frédéric Wang (:fredw)
Modified: 2017-11-15 13:10 PST (History)
9 users (show)

See Also:

Attachments
Patch (47.94 KB, patch)
2017-05-09 08:06 PDT, Frédéric Wang (:fredw) 		simon.fraser: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (900.46 KB, application/zip)
2017-05-09 09:17 PDT, Build Bot 		no flags Details
Patch for landing (49.46 KB, patch)
2017-05-09 09:27 PDT, Frédéric Wang (:fredw) 		fred.wang: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (49.46 KB, patch)
2017-05-09 09:29 PDT, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2017-05-09 07:52:26 PDT 
void ScrollingStateFrameScrollingNode::dumpProperties(TextStream& ts, ScrollingStateTreeAsTextBehavior behavior) const
{
[...]
    // FIXME: dump more properties.
}
Comment 1 Frédéric Wang (:fredw) 2017-05-09 08:06:22 PDT 
Created attachment 309496 [details]
Patch
Comment 2 Build Bot 2017-05-09 09:17:19 PDT 
Comment on attachment 309496 [details]
Patch

Attachment 309496 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3706053

New failing tests:
tiled-drawing/scrolling/fixed/four-bars-zoomed.html
Comment 3 Build Bot 2017-05-09 09:17:20 PDT 
Created attachment 309504 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 4 Frédéric Wang (:fredw) 2017-05-09 09:27:33 PDT 
Created attachment 309506 [details]
Patch for landing
Comment 5 Frédéric Wang (:fredw) 2017-05-09 09:29:02 PDT 
Created attachment 309507 [details]
Patch for landing
Comment 6 Frédéric Wang (:fredw) 2017-05-09 09:29:18 PDT 
Comment on attachment 309506 [details]
Patch for landing

wrong patch
Comment 7 WebKit Commit Bot 2017-05-09 10:11:01 PDT 
Comment on attachment 309507 [details]
Patch for landing

Clearing flags on attachment: 309507

Committed r216511: <http://trac.webkit.org/changeset/216511>
Comment 8 Frédéric Wang (:fredw) 2017-10-30 08:13:57 PDT 
It looks like this bug was fixed, so closing it.
Comment 9 Radar WebKit Bug Importer 2017-11-15 13:10:58 PST 
<rdar://problem/35568925>