Bug 171802 – Simplify ScrollingStateNode::scrollingStateTreeAsText

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Frédéric Wang (:fredw)]

Dumping of the scrolling state tree can be simplified using TextStream's helper functions.

[Frédéric Wang (:fredw)]

Created attachment 309353 [details]
Patch

[Build Bot]

Attachment 309353 [details] did not pass style-queue:


ERROR: Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp:195:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp:196:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp:202:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp:203:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp:209:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp:210:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp:216:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp:217:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 8 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Frédéric Wang (:fredw)]

Created attachment 309354 [details]
Patch

[Build Bot]

Comment on attachment 309354 [details]
Patch

Attachment 309354 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3698673

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 309356 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 309354 [details]
Patch

Attachment 309354 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3698733

New failing tests:
fast/scrolling/ios/remove-scrolling-role.html

[Build Bot]

Created attachment 309357 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Frédéric Wang (:fredw)]

Created attachment 309358 [details]
Patch

[Build Bot]

Attachment 309358 [details] did not pass style-queue:


ERROR: Source/WebCore/page/scrolling/ScrollingStateNode.cpp:139:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/page/scrolling/ScrollingStateNode.cpp:140:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/page/scrolling/ScrollingStateNode.cpp:141:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/page/scrolling/ScrollingStateNode.cpp:142:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/page/scrolling/ScrollingStateNode.cpp:143:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 5 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 309358 [details]
Patch

Attachment 309358 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3699111

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 309361 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 309358 [details]
Patch

Attachment 309358 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3699178

New failing tests:
fast/scrolling/ios/remove-scrolling-role.html

[Build Bot]

Created attachment 309364 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Frédéric Wang (:fredw)]

Created attachment 309367 [details]
Patch

[Frédéric Wang (:fredw)]

@Simon: Can you please review this patch?

I tried to keep the changes in the text output minimal, that's why ScrollingStateNode::dump does not use TextStream::GroupScope.

[Simon Fraser (smfr)]

Comment on attachment 309367 [details]
Patch

Cool, thanks for doing this! Its was on my to-do list.

We'll probably have to rebaseline some iOS results.

[Frédéric Wang (:fredw)]

(In reply to Simon Fraser (smfr) from comment #16)
> Comment on attachment 309367 [details]
> Patch
> 
> Cool, thanks for doing this! Its was on my to-do list.

No problem. I plan to submit follow-up patches to improve scrolling (state) tree nodes...

> We'll probably have to rebaseline some iOS results.

Do you mean on platforms not tested by the commit queue? If so, I'll probably land this tomorrow, so that I can watch the buildbot.

[WebKit Commit Bot]

Comment on attachment 309367 [details]
Patch

Clearing flags on attachment: 309367

Committed r216478: <http://trac.webkit.org/changeset/216478>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.