Bug 171823 – Update Chrome and Firefox versions in user agent quirks

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Michael Catanzaro]

Update Chrome and Firefox versions in user agent quirks

[Michael Catanzaro]

(I wonder what this will break.)

[Michael Catanzaro]

Created attachment 309404 [details]
Patch

[Carlos Garcia Campos]

(In reply to Michael Catanzaro from comment #1)
> (I wonder what this will break.)

Why do we want this if you think it's going to break something? I don't think we should do this unless it fixes anything.

[Michael Catanzaro]

Well we know websites are definitely going to break eventually if we don't do it. E.g. you'll get unsupported browser warnings in GMail. So we should do it.

But I would err on the side of not backporting it to 2.16 until we know it's needed to fix something.

[Carlos Alberto Lopez Perez]

Gmail will stop working with chrome53 https://gsuiteupdates.googleblog.com/2017/02/gmail-no-longer-supporting-chrome-v53.html

Soon similar things will happen for chrome56, etc.

I think keeping updated the version to the last one (or almost) is something sane.

People running chrome or firefox are usually running the last version (they are evergreen browsers -- they update themselves automatically without asking the user).

So sites that test for the chrome or firefox version usually do this as way to see if you don't have an obsolete browser.

[Carlos Alberto Lopez Perez]

Comment on attachment 309404 [details]
Patch

r=me, but please test that this doesn't break any major site

[Michael Catanzaro]

(In reply to Carlos Alberto Lopez Perez from comment #6)
> Comment on attachment 309404 [details]
> Patch
> 
> r=me, but please test that this doesn't break any major site

Note these versions are only used for our quirks, so Firefox UA bump only affects Google and the Chrome UA bump only affects TypeKit and Slack (but see bug #171869).

[WebKit Commit Bot]

Comment on attachment 309404 [details]
Patch

Clearing flags on attachment: 309404

Committed r216531: <http://trac.webkit.org/changeset/216531>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.