Bug 171869 - Remove user agent quirk for Slack
Summary: Remove user agent quirk for Slack
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-09 11:29 PDT by Michael Catanzaro
Modified: 2017-05-10 07:50 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.41 KB, patch)
2017-05-09 11:30 PDT, Michael Catanzaro
cgarcia: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (841.43 KB, application/zip)
2017-05-09 12:43 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2017-05-09 11:29:07 PDT
The user agent quirk for Slack does not seem to be necessary anymore. I am able to use Slack without difficulty using our default user agent. The quirk is not causing any harm, so there's no need to backport this to stable just in case I've messed up, but we should not retain quirks in trunk when they are no longer necessary.
Comment 1 Michael Catanzaro 2017-05-09 11:30:45 PDT
Created attachment 309517 [details]
Patch
Comment 2 Build Bot 2017-05-09 12:43:10 PDT
Comment on attachment 309517 [details]
Patch

Attachment 309517 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3706904

New failing tests:
imported/w3c/web-platform-tests/streams/readable-byte-streams/general.html
Comment 3 Build Bot 2017-05-09 12:43:11 PDT
Created attachment 309525 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 4 Carlos Garcia Campos 2017-05-10 00:36:05 PDT
Comment on attachment 309517 [details]
Patch

Don't we have a unit tests checking this quirk too?
Comment 5 Michael Catanzaro 2017-05-10 07:47:49 PDT
Yup, good catch
Comment 6 Michael Catanzaro 2017-05-10 07:50:06 PDT
Committed r216585: <http://trac.webkit.org/changeset/216585>