We are checking the errors only by their code, which can be the same in other domains. We should always check both the domain and the code.
Created attachment 309157 [details] Patch
Comment on attachment 309157 [details] Patch I am curious, what does this fix?
I noticed this while working on bug #171722, so I don't know what it fixed, but for example, if we receive a GST_RESOURCE_ERROR_OPEN_WRITE error, it will be handled as a format error because the code is the same as GST_STREAM_ERROR_CODEC_NOT_FOUND.
Committed r216239: <http://trac.webkit.org/changeset/216239>
It would be good to grep for other uses of GStreamer error codes to ensure we didn't make this same mistake in other places.
(In reply to Michael Catanzaro from comment #5) > It would be good to grep for other uses of GStreamer error codes to ensure > we didn't make this same mistake in other places. I did it when I noticed the problem.